Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth): handle no user scenario #3556

Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(oauth): handle no user scenario #3556

merged 1 commit into from
Jul 20, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jul 20, 2023

Context

There is an edge case where user is not defined, and we don't have access token, this gets handled next time we hit the function

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 1b60ae1
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64b953a594dd9c0008273478
😎 Deploy Preview https://deploy-preview-3556--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 1b60ae1
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64b953a57a0cd60008e7538d
😎 Deploy Preview https://deploy-preview-3556--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi requested a review from jbocce July 20, 2023 15:33
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #3556 (1b60ae1) into master (d5cbbb0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3556   +/-   ##
=======================================
  Coverage   42.75%   42.75%           
=======================================
  Files          82       82           
  Lines        1450     1450           
  Branches      338      338           
=======================================
  Hits          620      620           
  Misses        667      667           
  Partials      163      163           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d88978...1b60ae1. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 20, 2023

Passing run #3382 ↗︎

0 36 0 0 Flakiness 0

Details:

fix(oauth): handle no user scenario
Project: Viewers Commit: 1b60ae18cb
Status: Passed Duration: 03:15 💡
Started: Jul 20, 2023 3:38 PM Ended: Jul 20, 2023 3:41 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants