feat(4D-ROI): ROI Segmentation panel (4D) #3574
Conversation
| toolGroupIds: ['dynamic4D-default'], | ||
| // -1 would be used to indicate active only, whereas other values are | ||
| // the number of required priors referenced - so 0 means active with | ||
| // 0 or more priors. | ||
| numberOfPriorsReferenced: 0, | ||
| // Default viewport is used to define the viewport when | ||
| // additional viewports are added using the layout tool | ||
| defaultViewport: { | ||
| viewportOptions: { | ||
| viewportType: 'volume', | ||
| toolGroupId: 'dynamic4D-default', | ||
| allowUnmatchedView: true, | ||
| initialImageOptions: { | ||
| preset: 'middle', // 'first', 'last', 'middle' | ||
| }, | ||
| }, | ||
| displaySets: [ | ||
| { | ||
| id: 'defaultDisplaySetId', | ||
| matchedDisplaySetsIndex: -1, | ||
| }, | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Just trying to make it more similar to TMTV
Codecov Report
@@ Coverage Diff @@
## feat/preclinical-4d-base #3574 +/- ##
=========================================================
Coverage 42.75% 42.75%
=========================================================
Files 82 82
Lines 1450 1450
Branches 338 338
=========================================================
Hits 620 620
Misses 667 667
Partials 163 163 Continue to review full report in Codecov by Sentry.
|
modes/preclinical-4d/src/index.tsx
Outdated
| stageId: 'dataPreparation', | ||
| }, | ||
| }, | ||
| { | ||
| id: 'registration', | ||
| name: 'Registration', | ||
| hangingProtocol: { | ||
| protocolId: 'default4D', | ||
| protocolId: preclinical4d.hangingProtocol, |
There was a problem hiding this comment.
I thought in each step we are applying a new protocol no?
There was a problem hiding this comment.
No. Each step moves to the next HP stage
There was a problem hiding this comment.
hmmm this is confusing then and requires the a preexisting knowledge of the hanging protcol and that it should have multiple stages defined. Explicit code is much better in this situation so at least put a stage index or something as the argument
There was a problem hiding this comment.
I'm not sure if I'm following because all workflow stages are using the same protocolId but each one of them has a different stageId.
There was a problem hiding this comment.
Nevermind I understand now. Also when did we choose to add workflow to the mode root key? I thought we are using it in the onModeEnter and register the steps via the workflowService no?
Also seems like we have stages in the HP and stages in workflow which is a lot confusing we should think about how to rename the workflow stage to something else. I think we should opt in for WorkflowStep and WorkflowStepService
There was a problem hiding this comment.
Renamed "stages" to "steps" everywhere
| @@ -280,7 +277,8 @@ function getFusionViewports() { | |||
| } | |||
|
|
|||
| const defaultProtocol = { | |||
| id: 'default4D', | |||
| id: | |||
There was a problem hiding this comment.
i don't think you should make the full pathname here, if you say 'default' it automatically should create the @ohif/extension-cornerstone-dynamic-volume.hangingProtocolModule.default if i'm not mistaken
There was a problem hiding this comment.
I changed the id when I was comparing it with TMTV HP and I saw that one using @ohif/extension-tmtv.hangingProtocolModule.ptCT as id
There was a problem hiding this comment.
does it work if you say default here? if so please do so
There was a problem hiding this comment.
It works if we set it to default because it would use the default HP from default mode but I've reverted my change renaming the HP back to default4D
extensions/cornerstone/src/services/ToolGroupService/ToolGroupService.ts
Outdated
Show resolved
Hide resolved
|
ToolGroupServicesto make it possible to add tool instances (eg: circular brush/eraser tools are instances of BrushTool)calculateSUVPeakto support 4D datasets since volumes can have multiple arrays ofscalarDataBrushConfigurationcomponent to make it possible to change all brush-related tools settingsthresholdSegmentationByRectangleROIToolandcalculatedSUVPeakfrom TMTV to also supportRectangle ROI Threshold(onlyRectangle ROI Threshold (start/end)was supported before)ToolServiceto be able to trigger and listen to events (activated tools)toolGroup) + a few other changes to make it similar to HP from TMTVViewportWindowLevelrelated to segmentations