Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix rgb inconsistencies by updating cs3d image loader #3604

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

igoroctaviano
Copy link
Contributor

Fix rgb inconsistencies by updating cs3d image loader version

Closes: #3354

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Fix rgb inconsistencies by updating cs3d image loader version

✅ Closes: #3354
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 83e56fb
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64dd0eec96a26a00080a5d07
😎 Deploy Preview https://deploy-preview-3604--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 83e56fb
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64dd0eec3ef5d400080703f7
😎 Deploy Preview https://deploy-preview-3604--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #3604 (83e56fb) into master (0f9b369) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3604   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede6300...83e56fb. Read the comment docs.

@cypress
Copy link

cypress bot commented Aug 16, 2023

Passing run #3464 ↗︎

0 37 0 0 Flakiness 0

Details:

Merge branch 'master' into fix/address-rgb-issues-bump-cs3d-libs
Project: Viewers Commit: 83e56fb965
Status: Passed Duration: 03:35 💡
Started: Aug 16, 2023 6:07 PM Ended: Aug 16, 2023 6:11 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@igoroctaviano
Copy link
Contributor Author

@sedghi this is to close #3354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] v3 and v2: RGB inconsistencies
2 participants