Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(i18n): display set(s) are two words for English messages #3711

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix(i18n): display set(s) are two words for English messages #3711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4832cc5
fix(i18n): display set(s) are two words for English messages.
Oct 10, 2023
7720108
Missed string.
Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions platform/i18n/src/locales/en-US/Messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"1": "No valid instances found in series.",
"2": "DisplaySet has missing position information.",
"3": "DisplaySet is not a reconstructable 3D volume.",
"4": "Multi frame displaySet don't have pixel measurement information.",
"5": "Multi frame displaySet don't have orientation information.",
"6": "Multi frame displaySet don't have position information.",
"7": "DisplaySet has missing frames.",
"8": "DisplaySet has irregular spacing.",
"9": "DisplaySet has inconsistent dimensions between frames.",
"10": "DisplaySet has frames with inconsistent number of components.",
"11": "DisplaySet has frames with inconsistent orientations.",
"12": "DisplaySet has inconsistent position information.",
"13": "Unsupported displaySet."
"2": "Display set has missing position information.",
"3": "Display set is not a reconstructable 3D volume.",
"4": "Multi frame display sets do not have pixel measurement information.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of contractions for "things that are published". But maybe I am picky. lol

"5": "Multi frame display sets do not have orientation information.",
"6": "Multi frame display sets do not have position information.",
"7": "Display set has missing frames.",
"8": "Display set has irregular spacing.",
"9": "Display set has inconsistent dimensions between frames.",
"10": "Display set has frames with inconsistent number of components.",
"11": "Display set has frames with inconsistent orientations.",
"12": "Display set has inconsistent position information.",
"13": "Unsupported display set."
}
2 changes: 1 addition & 1 deletion platform/ui/src/components/DisplaySetMessageListTooltip/DisplaySetMessageListTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const DisplaySetMessageListTooltip = ({ messages, id }): React.ReactNode => {
marginTop: '12px',
}}
>
DisplaySet Messages
Display Set Messages
</div>
<ol
style={{
Expand Down