Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toolbar): new Toolbar to enable reactive state synchronization #3983

Merged
merged 88 commits into from
Mar 27, 2024
Merged

feat(toolbar): new Toolbar to enable reactive state synchronization #3983

merged 88 commits into from
Mar 27, 2024

Commits on Feb 21, 2024

  1. Remove unused storeContexts from commandsModule

    @sedghi
    sedghi committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    689d2c7 View commit details
    Browse the repository at this point in the history

  2. Refactor code and fix linting issues

    @sedghi
    sedghi committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    98844c4 View commit details
    Browse the repository at this point in the history

  3. clean up mode tsx

    @sedghi
    sedghi committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d15c4ea View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Add AppContextService and update contextProviders

    @sedghi
    sedghi committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d554aa9 View commit details
    Browse the repository at this point in the history

  2. Refactor toolbar and remove unused code

    @sedghi
    sedghi committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b9e6dd0 View commit details
    Browse the repository at this point in the history

  3. Refactor toolbar buttons and add tooltips

    @sedghi
    sedghi committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    066e2dc View commit details
    Browse the repository at this point in the history

  4. Update Toolbar and ViewportGrid components

    @sedghi
    sedghi committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    f91eb94 View commit details
    Browse the repository at this point in the history

  5. Refactor UI and contextProviders modules

    @sedghi
    sedghi committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    8fc36e5 View commit details
    Browse the repository at this point in the history

  6. Add disabled state to toolbar buttons and side panel tabs

    @sedghi
    sedghi committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    1b098cc View commit details
    Browse the repository at this point in the history

  7. Refactor ViewerLayout and App components

    @sedghi
    sedghi committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    dbe5214 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Refactor toolbar button handling and add display set condition

    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    03187bd View commit details
    Browse the repository at this point in the history

  2. Refactor toolbar button handling logic

    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c4455cf View commit details
    Browse the repository at this point in the history

  3. Add button condition for displaySets.isReconstructable*** 

    ***Add button condition for toolGroup.id !== 'mpr'***
***Update ListMenu component to handle disabled items***
***Add evaluateToolbarButtonState module
    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8892b16 View commit details
    Browse the repository at this point in the history

  4. Refactor toolbar button evaluation and update list menu theme

    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7a9735c View commit details
    Browse the repository at this point in the history

  5. Remove isActive property from moreTools and toolbarButtons

    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e9554e1 View commit details
    Browse the repository at this point in the history

  6. Refactor toolbar button state handling

    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8035802 View commit details
    Browse the repository at this point in the history

  7. Refactor toolbar button toggling logic

    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    fb39375 View commit details
    Browse the repository at this point in the history

  8. Refactor Toolbar component and ToolbarService

    @sedghi
    sedghi committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1666c73 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Add SplitButtonToolbar component

    @sedghi
    sedghi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    e2b6f19 View commit details
    Browse the repository at this point in the history

  2. clean up

    @sedghi
    sedghi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    869c80f View commit details
    Browse the repository at this point in the history

  3. Update dependencies in package.json

    @sedghi
    sedghi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8b307a0 View commit details
    Browse the repository at this point in the history

  4. remove toolbarservice init

    @sedghi
    sedghi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0be2f51 View commit details
    Browse the repository at this point in the history

  5. Refactor toolbarButtons.js and commandsModule.ts

    @sedghi
    sedghi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b34cf95 View commit details
    Browse the repository at this point in the history

  6. Fix toolbar button and interaction issues

    @sedghi
    sedghi committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8154820 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Fix toolGroup method calls in commandsModule and init.tsx

    @sedghi
    sedghi committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e8c350b View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Update Cornerstone extension: remove unused code and add toolbar module

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d5d8024 View commit details
    Browse the repository at this point in the history

  2. Refactor button background classes and remove unused props

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bd55f08 View commit details
    Browse the repository at this point in the history

  3. Refactor toolbar buttons and evaluate functions

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7520f77 View commit details
    Browse the repository at this point in the history

  4. add nested button support for new architecture

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d88f95e View commit details
    Browse the repository at this point in the history

  5. Fix UI styling issues in IconButton, Toolbar, SplitButton, and Toolba… 

    …rButton components
    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fad70dc View commit details
    Browse the repository at this point in the history

  6. Update toolbar module styling

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1f6283a View commit details
    Browse the repository at this point in the history

  7. Remove commented out code in ToolbarService.ts

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9f21e1e View commit details
    Browse the repository at this point in the history

  8. Remove moreToolsMpr import and related code

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1992370 View commit details
    Browse the repository at this point in the history

  9. new api for toolbar buttons for all modes

    @sedghi
    sedghi committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    516344d View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Refactor UI styling and remove unnecessary code

    @sedghi
    sedghi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    846584f View commit details
    Browse the repository at this point in the history

  2. Refactor toolbar evaluation and button props

    @sedghi
    sedghi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    71de18c View commit details
    Browse the repository at this point in the history

  3. Remove cleanUpCrosshairs command and update getToolbarModule

    @sedghi
    sedghi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ae3ac01 View commit details
    Browse the repository at this point in the history

  4. Refactor image slice synchronization

    @sedghi
    sedghi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    2fcf360 View commit details
    Browse the repository at this point in the history

  5. Update dependencies and fix toolbar button styling

    @sedghi
    sedghi committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f5fa155 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fix code formatting and update type annotations

    @sedghi
    sedghi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1ea33b3 View commit details
    Browse the repository at this point in the history

  2. Remove unused code and functions

    @sedghi
    sedghi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    07f64b3 View commit details
    Browse the repository at this point in the history

  3. Fix evaluate.group.promoteToPrimaryIfCornerstoneToolNotActiveInTheList

    @sedghi
    sedghi committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1126466 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'master' of github.com:OHIF/Viewers into feat/app-context

    @sedghi
    sedghi committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    e018490 View commit details
    Browse the repository at this point in the history

  2. general toolbox component

    @sedghi
    sedghi committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cace7ee View commit details
    Browse the repository at this point in the history

  3. Add ToolWithStackedOptions component and segmentation buttons to toolbar

    @sedghi
    sedghi committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ce58dd8 View commit details
    Browse the repository at this point in the history

  4. Add Toolbox component and ToolboxContainer to default extension

    @sedghi
    sedghi committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5e44242 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Remove Toolbox component and update button section in Segmentation mode

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    312aa8c View commit details
    Browse the repository at this point in the history

  2. cine service

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5a1b52a View commit details
    Browse the repository at this point in the history

  3. Remove AppContextService and AppContextProvider

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7c162ed View commit details
    Browse the repository at this point in the history

  4. Update IconButton variant classes

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b8780df View commit details
    Browse the repository at this point in the history

  5. Refactor toolbarButtons.js and init.js

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    68c4f2d View commit details
    Browse the repository at this point in the history

  6. isReady

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    91f760b View commit details
    Browse the repository at this point in the history

  7. Update positions of categories in JSON files and remove unused code

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    ac96a14 View commit details
    Browse the repository at this point in the history

  8. Refactor tooltips to display secondary content

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    cd6934f View commit details
    Browse the repository at this point in the history

  9. Update dependencies and remove unused code

    @sedghi
    sedghi committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    10cacf0 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Add toolbar event registration for cornerstone tools

    @sedghi
    sedghi committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    a3f9f7e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Update Command and Toolbar Modules

    @sedghi
    sedghi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e44ffbf View commit details
    Browse the repository at this point in the history

  2. Remove unused options from commandsModule

    @sedghi
    sedghi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1757d9f View commit details
    Browse the repository at this point in the history

  3. apply review comments

    @sedghi
    sedghi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    51b0c87 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Update canvas width and height for maintaining aspect ratio in thumbn… 

    …ail images
    @sedghi
    sedghi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    b8bbd55 View commit details
    Browse the repository at this point in the history

  2. toggle sync with sync id

    @sedghi
    sedghi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0d67e22 View commit details
    Browse the repository at this point in the history

  3. Update getViewportModule to include commandsManager parameter

    @sedghi
    sedghi committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    ac22228 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Add file loader for wasm file and import ToolbarButton in SplitButton… 

    … stories
    @sedghi
    sedghi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    c3040f8 View commit details
    Browse the repository at this point in the history

  2. fix button group stuff

    @sedghi
    sedghi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ce0cd92 View commit details
    Browse the repository at this point in the history

  3. Update canvas width and height for thumbnail images

    @sedghi
    sedghi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2155d86 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Update segmentation toolbox buttons

    @sedghi
    sedghi committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    773c3cc View commit details
    Browse the repository at this point in the history

  2. Refactor toolbar buttons and button groups

    @sedghi
    sedghi committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    808fc5d View commit details
    Browse the repository at this point in the history

  3. Update button sizes and icons

    @sedghi
    sedghi committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    acc7aae View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Add ToolboxUI component and update imports

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    f1396cd View commit details
    Browse the repository at this point in the history

  2. Update imports and components in codebase

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    3754871 View commit details
    Browse the repository at this point in the history

  3. Add ToolboxProvider to App component and pass props to Toolbox component

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0e491d6 View commit details
    Browse the repository at this point in the history

  4. Refactor evaluate function in getToolbarModule and segmentationButtons

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6f3753b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:OHIF/Viewers into feat/app-context

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    df68d29 View commit details
    Browse the repository at this point in the history

  6. Fix issue with URL object creation in updateAuthServiceAndCleanUrl fu… 

    …nction
    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    47cde98 View commit details
    Browse the repository at this point in the history

  7. Add toolbarButtons import and update documentation

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    7aa8ed6 View commit details
    Browse the repository at this point in the history

  8. Refactor toolbarButtons.js

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    870ad9e View commit details
    Browse the repository at this point in the history

  9. Refactor UI components and fix styling issues

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    f616dd8 View commit details
    Browse the repository at this point in the history

  10. Add new toolbar buttons and update button styles

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    49b076d View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary code in MPR.spec.js

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    536285c View commit details
    Browse the repository at this point in the history

  12. Toggle ReferenceLines and ImageOverlayViewer tools

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    d217cda View commit details
    Browse the repository at this point in the history

  13. Update SyncGroupService, segmentationButtons, and MeasurementService*** 

    ***Description:***
This commit updates the SyncGroupService, segmentationButtons, and MeasurementService files.

In SyncGroupService, the code has been modified to handle cases where the renderingEngine is not found for a given viewportId. It now falls back to the first renderingEngine in the list.

In segmentationButtons, the default values for the brush size, eraser size, and threshold size have been changed from 15 to 25.

In MeasurementService, the unmappedMeasurements variable has been changed from a Set to a Map. Additionally, a new error handling logic has been added to handle cases where mapping fails.

In toolbar.md, a new section has been added to explain how to change the toolbar based on the hanging protocol.

***Note:
    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    030280e View commit details
    Browse the repository at this point in the history

  14. unit tests

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    ad06de6 View commit details
    Browse the repository at this point in the history

  15. fix e2e tests

    @sedghi
    sedghi committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    6964eef View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Refactor UI components and update imports

    @sedghi
    sedghi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    03129c4 View commit details
    Browse the repository at this point in the history

  2. remove spellcheck for no

    @sedghi
    sedghi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1a3ee1f View commit details
    Browse the repository at this point in the history

  3. Add toggleThresholdRangeAndDynamic command and dynamicRadius configur… 

    …ation
    @sedghi
    sedghi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2a8c7bf View commit details
    Browse the repository at this point in the history

  4. Update ToolbarButton and commandsModule components

    @sedghi
    sedghi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    30a167e View commit details
    Browse the repository at this point in the history

  5. review comment

    @sedghi
    sedghi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2141064 View commit details
    Browse the repository at this point in the history