feat(worklist): New worklist buttons and tooltips #3989

IbrahimCSAE · 2024-03-14T08:21:18Z

Context

Address #3960
Also fixes issue with dialogs and modals not dismissing on mode exit.

Changes & Results

New button design
New tooltips

Note

Investigational use changes is a separate pull later on.

netlify · 2024-03-14T08:21:34Z

✅ Deploy Preview for ohif-platform-docs ready!

Name	Link
🔨 Latest commit	`4c079c6`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/65f8d84c49cd420008b0db83
😎 Deploy Preview	https://deploy-preview-3989--ohif-platform-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-03-14T08:21:35Z

✅ Deploy Preview for ohif-dev ready!

Name	Link
🔨 Latest commit	`4c079c6`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/65f8d84c8044a50008875824
😎 Deploy Preview	https://deploy-preview-3989--ohif-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-03-14T08:40:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (21ec686) to head (4c079c6).
Report is 6 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3989   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files          80       80           
  Lines        1332     1332           
  Branches      327      327           
=======================================
  Hits          592      592           
  Misses        587      587           
  Partials      153      153

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ec686...4c079c6. Read the comment docs.

cypress · 2024-03-14T08:47:52Z

4 failed tests on run #3762 ↗︎

4	40	0	0	0

Details:

hide modals and dialogs on mode exit
Project: Viewers	Commit: `9cbd70979e`
Status: Failed	Duration: 07:06 💡
Started: Mar 14, 2024 8:40 AM	Ended: Mar 14, 2024 8:47 AM

cypress/integration/study-list/OHIFStudyList.spec.js • 4 failed tests

View Output Video

Test		Artifacts
OHIF Study List > Desktop resolution > maintains Patient Name filter upon return from viewer		`Test Replay` `Screenshots` `Video`
OHIF Study List > Desktop resolution > maintains MRN filter upon return from viewer		`Test Replay` `Screenshots` `Video`
OHIF Study List > Desktop resolution > maintains Accession filter upon return from viewer		`Test Replay` `Screenshots` `Video`
OHIF Study List > Desktop resolution > maintains Description filter upon return from viewer		`Test Replay` `Screenshots` `Video`

Review all test suite changes for PR #3989 ↗︎

platform/ui/src/components/Button/Button.tsx

platform/app/src/routes/WorkList/WorkList.tsx

sedghi

Looks good, see my comments please

sedghi · 2024-03-14T17:29:23Z

@IbrahimCSAE Can you please add a configuration inside the app config that can people choose in their configurations like default.js and the configuration is about whether to group the enabled modes together at the front and then show the disabled ones. I think that adds a lot of value.

IbrahimCSAE · 2024-03-19T00:12:03Z

@IbrahimCSAE Can you please add a configuration inside the app config that can people choose in their configurations like default.js and the configuration is about whether to group the enabled modes together at the front and then show the disabled ones. I think that adds a lot of value.

Done

sedghi

Looks great thanks

* chore(version): Update package versions [skip ci] * feat(displayArea): add display area to hanging protocol (OHIF#3691) Co-authored-by: Ouwen Huang <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(debug): Add timing information about time to first image/all images, and query time (OHIF#3681) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cli): Add npm packaged mode not working (OHIF#3689) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(translation): Side panel translate fix (OHIF#3156) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(locale): Added Turkish language support (tr-TR) - Community PR (OHIF#3695) Co-authored-by: Ahmet Altay <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(locale): add German translations - community PR (OHIF#3697) Co-authored-by: pwespi <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(measurement and microscopy): various small fixes for measurement and microscopy side panel (OHIF#3696) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation scroll): and hydration bugs (OHIF#3701) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(bugs): fixing lots of bugs regarding release candidate (OHIF#3700) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(Segmentation): download RTSS from Labelmap(OHIF#3692) Co-authored-by: Alireza <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): do not use SAB if not specified (OHIF#3705) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(modality unit): fix the modality unit per target via upgrade of cs3d (OHIF#3706) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(voi): should publish voi change event on reset (OHIF#3707) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): Various fixes for segmentation mode and other (OHIF#3709) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(modules): add stylus loader as an option to be uncommented (OHIF#3710) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(i18n): display set(s) are two words for English messages (OHIF#3711) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(export): wrong export for the tmtv RT function (OHIF#3715) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(display messages): broken after timings (OHIF#3719) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): move to the next beta version [BUMP BETA] * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(calibration): No calibration popup caused by perhaps an unused code optimization for production builds (OHIF#3736) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cine): Use the frame rate specified in DICOM and optionally auto play cine (OHIF#3735) Co-authored-by: rareramos <[email protected]> Co-authored-by: Doug Horner <[email protected]> Co-authored-by: Rehan <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(recipes): package.json script orthanc:up docker-compose path (OHIF#3741) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs(azure): Azure static Deployment details (OHIF#3740) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(sr): dcm4chee requires the patient name for an SR to match what is in the original study (OHIF#3739) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(toolbar): allow customizable toolbar for active viewport and allow active tool to be deactivated via a click (OHIF#3608) Co-authored-by: Joe Boccanfuso <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(measurement service): Implemented correct check of schema keys in _isValidMeasurment. (OHIF#3750) * feat(filters): save worklist query filters to session storage so that they persist between navigation to the viewer and back (OHIF#3749) Co-authored-by: ladeirarodolfo <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(i18n): enhanced i18n support (OHIF#3730) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(thumbnail): Avoid multiple promise creations for thumbnails (OHIF#3756) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs(faq): FAQ and Segmentation Mode Fix for some studies (OHIF#3762) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(hp callback): Add viewport ready callback (OHIF#3772) Co-authored-by: Ouwen Huang <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: add VolumeViewport rotation (OHIF#3776) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(arrow): ArrowAnnotate text key cause validation error (OHIF#3771) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(path): upgrade docusaurus for security (OHIF#3780) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(dicomJSON): Add Loading Other Display Sets and JSON Metadata Generation script (OHIF#3777) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(overlay): Overlays aren't shown on undefined origin (OHIF#3781) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: 🐛 Run error handler for failed image requests (OHIF#3773) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(url): Add SeriesInstanceUIDs wado query param (OHIF#3746) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(docs): Added various training videos to support the OHIF CLI tools (OHIF#3794) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(metadata): to handle cornerstone3D update for htj2k (OHIF#3783) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(DICOM Overlay): The overlay data wasn't being refreshed on change (OHIF#3793) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(events): broadcast series summary metadata (OHIF#3798) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: Merge Data Source (OHIF#3788) Add the ability to merge two different series queries to generate a complete study query result. Provides basic support for other types of merges, but those aren't yet added as full features. * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: Update the CS3D packages to add the most recent HTJ2K TSUIDS (OHIF#3806) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cine): Set cine disabled on mode exit. (OHIF#3812) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(SM): drag and drop is now fixed for SM (OHIF#3813) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(auth): fix the issue with oauth at a non root path (OHIF#3840) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(HP): Added new 3D hanging protocols to be used in the new layout selector (OHIF#3844) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(i18n): enhanced i18n support (OHIF#3761) * fix: address and improve system vulnerabilities (OHIF#3851) * feat(config): Add activateViewportBeforeInteraction parameter for viewport interaction customization (OHIF#3847) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(customizationService): Enable saving and loading of private tags in SRs (OHIF#3842) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * Fix(HPService): custom image load performed is now reset to false on HP exit (OHIF#3809) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(dicom-seg) : Fix the missing color tag when loading Dicom-Seg (OHIF#3822) Co-authored-by: Alireza <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update HangingProtocolService.md doc sameAs example to contain constr… (OHIF#3765) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(overlay): add inline binary overlays (OHIF#3852) * fix(icon-style): Ensure consistent icon dimensions (OHIF#3727) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): upgrade cornerstone3D versions (OHIF#3853) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * chore(version): upgrade cornerstone3D versions to fix orientation (OHIF#3854) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: colormap for stack viewports via HangingProtocol (OHIF#3866) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: convert radian to degree value for mip rotation (OHIF#3881) * fix: PDF display request in v3 (OHIF#3878) Co-authored-by: Alireza <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: improve disableEditing flag (OHIF#3875) Co-authored-by: Igor Octaviano <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(ui): sidePanel expandedWidth (OHIF#3728) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat: Add on mode init hook (OHIF#3882) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update user-account-control.md (OHIF#3877) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(segmentation): upgrade cs3d to fix various segmentation bugs (OHIF#3885) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(transferSyntax): prefer server transcoded transfer syntax for all images (OHIF#3883) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(hp): enable OHIF to run with partial metadata for large studies at the cost of less effective hanging protocol (OHIF#3804) Co-authored-by: rodrigobasilio2022 <[email protected]> Co-authored-by: rodrigobasilio2022 <[email protected]> * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: Update CS3D to fix second render (OHIF#3892) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Update architecture.md (OHIF#3891) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: 🐛 Check merge key for merge data source (OHIF#3901) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: is same orientaiton (OHIF#3905) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(viewport-sync): remember synced viewports bw stack and volume and RENAME StackImageSync to ImageSliceSync (OHIF#3849) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: catch errors in getPTImageIdInstanceMetadata (OHIF#3897) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix toggleHpTools to support split primary button (OHIF#3900) Fixes a small bug in toggling buttons with hanging protocols. * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix: 🐛 Sort merge results based on default data source (input) (OHIF#3903) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(errorboundary): format stack trace properly (OHIF#3931) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(resize): Optimize resizing process and maintain zoom level (OHIF#3889) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(demo): Deploy issue (OHIF#3951) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(docs): Minor typos in hpModule.md (OHIF#3962) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * docs: Typo (OHIF#3975) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(cli): mode creation template (OHIF#3876) (OHIF#3981) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(delete measurement): icon for measurement table (OHIF#3775) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * fix(SR display): and the token based navigation (OHIF#3995) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] * feat(worklist): New worklist buttons and tooltips (OHIF#3989) * chore(version): version.json [skip ci] * chore(version): Update package versions [skip ci] --------- Co-authored-by: ohif-bot <[email protected]> Co-authored-by: Alireza <[email protected]> Co-authored-by: Ouwen Huang <[email protected]> Co-authored-by: Bill Wallace <[email protected]> Co-authored-by: Joe Boccanfuso <[email protected]> Co-authored-by: wangxuan <[email protected]> Co-authored-by: Ahmet Altay <[email protected]> Co-authored-by: pwespi <[email protected]> Co-authored-by: dxlin <[email protected]> Co-authored-by: rareramos <[email protected]> Co-authored-by: Doug Horner <[email protected]> Co-authored-by: Rehan <[email protected]> Co-authored-by: edwardyangxin <[email protected]> Co-authored-by: bluesteel23 <[email protected]> Co-authored-by: Joe Boccanfuso <[email protected]> Co-authored-by: ladeirarodolfo <[email protected]> Co-authored-by: Pavel <[email protected]> Co-authored-by: Ouwen Huang <[email protected]> Co-authored-by: Pedro H. Köhler <[email protected]> Co-authored-by: Igor Octaviano <[email protected]> Co-authored-by: Sofien-Sellami <[email protected]> Co-authored-by: Salim Kanoun <[email protected]> Co-authored-by: Celian-abd <[email protected]> Co-authored-by: AbishekBista9 <[email protected]> Co-authored-by: rodrigobasilio2022 <[email protected]> Co-authored-by: rodrigobasilio2022 <[email protected]> Co-authored-by: Ibrahim <[email protected]> Co-authored-by: EricB <[email protected]> Co-authored-by: EricB <[email protected]>

worklist updates

0dd7fdb

IbrahimCSAE requested a review from sedghi March 14, 2024 08:21

hide modals and dialogs on mode exit

9cbd709

sedghi reviewed Mar 14, 2024

View reviewed changes

platform/ui/src/components/Button/Button.tsx Outdated Show resolved Hide resolved

sedghi reviewed Mar 14, 2024

View reviewed changes

platform/app/src/routes/WorkList/WorkList.tsx Outdated Show resolved Hide resolved

sedghi reviewed Mar 14, 2024

View reviewed changes

finalized

4c079c6

IbrahimCSAE requested a review from sedghi March 19, 2024 00:12

sedghi approved these changes Mar 19, 2024

View reviewed changes

sedghi merged commit 9bcd1ae into master Mar 19, 2024
9 of 11 checks passed

IbrahimCSAE deleted the feat/worklist-ui-enhancements-buttons branch March 21, 2024 00:52

IbrahimCSAE restored the feat/worklist-ui-enhancements-buttons branch March 21, 2024 00:53

thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024

feat(worklist): New worklist buttons and tooltips (OHIF#3989)

ebfde6e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(worklist): New worklist buttons and tooltips #3989

feat(worklist): New worklist buttons and tooltips #3989

IbrahimCSAE commented Mar 14, 2024 •

edited

Loading

netlify bot commented Mar 14, 2024 •

edited

Loading

netlify bot commented Mar 14, 2024 •

edited

Loading

codecov bot commented Mar 14, 2024 •

edited

Loading

cypress bot commented Mar 14, 2024

sedghi left a comment

sedghi commented Mar 14, 2024

IbrahimCSAE commented Mar 19, 2024

sedghi left a comment

feat(worklist): New worklist buttons and tooltips #3989

feat(worklist): New worklist buttons and tooltips #3989

Conversation

IbrahimCSAE commented Mar 14, 2024 • edited Loading

Context

Changes & Results

Note

netlify bot commented Mar 14, 2024 • edited Loading

✅ Deploy Preview for ohif-platform-docs ready!

netlify bot commented Mar 14, 2024 • edited Loading

✅ Deploy Preview for ohif-dev ready!

codecov bot commented Mar 14, 2024 • edited Loading

Codecov Report

cypress bot commented Mar 14, 2024

4 failed tests on run #3762 ↗︎

Review all test suite changes for PR #3989 ↗︎

sedghi left a comment

Choose a reason for hiding this comment

sedghi commented Mar 14, 2024

IbrahimCSAE commented Mar 19, 2024

sedghi left a comment

Choose a reason for hiding this comment

IbrahimCSAE commented Mar 14, 2024 •

edited

Loading

netlify bot commented Mar 14, 2024 •

edited

Loading

netlify bot commented Mar 14, 2024 •

edited

Loading

codecov bot commented Mar 14, 2024 •

edited

Loading