Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): CircleCI and VS Code preferences #401

Merged
merged 23 commits into from
Apr 26, 2019

Conversation

dannyrb
Copy link
Member

@dannyrb dannyrb commented Apr 25, 2019

No description provided.

@dannyrb
Copy link
Member Author

dannyrb commented Apr 25, 2019

Having some issues generating CI Coverage -- Likely because of JSDOM setup. Looking into it 👀

@dannyrb
Copy link
Member Author

dannyrb commented Apr 26, 2019

Seeing this error while collecting coverage: vuejs/vue-cli#1453

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (react@a8dfc3d). Click here to learn what that means.
The diff coverage is 60%.

Impacted file tree graph

@@           Coverage Diff           @@
##             react    #401   +/-   ##
=======================================
  Coverage         ?   0.42%           
=======================================
  Files            ?      42           
  Lines            ?     701           
  Branches         ?      62           
=======================================
  Hits             ?       3           
  Misses           ?     636           
  Partials         ?      62
Impacted Files Coverage Δ
src/__tests__/globalSetup.js 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8dfc3d...ea4ea94. Read the comment docs.

@dannyrb dannyrb merged commit 0e59e02 into OHIF:react Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant