-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(advanced-roi-tools): new tools and icon updates and overlay bug fixes #4014
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #3793 ↗︎
Details:
Review all test suite changes for PR #4014 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4014 +/- ##
==========================================
- Coverage 46.23% 44.37% -1.87%
==========================================
Files 78 80 +2
Lines 1276 1334 +58
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 589 +41
- Partials 138 153 +15 see 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -124,7 +124,7 @@ const moreTools = [ | |||
evaluate: 'evaluate.viewportProperties.toggle', | |||
}), | |||
createButton({ | |||
id: 'Probe', | |||
id: 'DragProbe', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you changing this? Probe is fine
@@ -124,7 +124,7 @@ const moreTools = [ | |||
evaluate: 'evaluate.viewportProperties.toggle', | |||
}), | |||
createButton({ | |||
id: 'Probe', | |||
id: 'DragProbe', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
@@ -212,7 +212,7 @@ const toolbarButtons: Button[] = [ | |||
evaluate: 'evaluate.viewportProperties.toggle', | |||
}), | |||
createButton({ | |||
id: 'Probe', | |||
id: 'DragProbe', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
@@ -32,7 +32,7 @@ const ToolbarButton = ({ | |||
? toolTipClassName | |||
: sizeToUse === 'toolbar' | |||
? 'w-[40px] h-[40px]' | |||
: 'w-[32px] h-[32px]'; | |||
: 'w-[40px] h-[40px]'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is redundant
Context
Fixes
#3819
#3721
Changes & Results