Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the start/end command in TMTV for the ROIStartEndThreshold tools #4281

Merged

Conversation

Celian-abd
Copy link
Contributor

Context

(Awaiting the update of cornerstone packages in OHIF)
This PR is related to the following changes in this cornerstone PR cornerstonejs/cornerstone3D#1377

Changes & Results

  • Added the CircleROIStartEndThresholdTool to the measurement service
  • Update the start/end command to match the changes of the tools

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 63c400c
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/668ba239c9d7950008e9d0d3
😎 Deploy Preview https://deploy-preview-4281--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 63c400c
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/668ba2394856df0008a93dd6
😎 Deploy Preview https://deploy-preview-4281--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve conflicts please?

@Celian-abd Celian-abd requested a review from sedghi July 8, 2024 08:39
@sedghi sedghi changed the title feat: fix the start/end command in TMTV for the ROIStartEndThreshold tools fix: the start/end command in TMTV for the ROIStartEndThreshold tools Jul 9, 2024
@sedghi sedghi merged commit 38c19fa into OHIF:master Jul 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants