Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updateIndex): getNumberOfSlices is defined when used with a 3D viewport #4424

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Ceciliadrc
Copy link
Contributor

Context

This PR fix getNumberOfSlices that is not defined in 3D viewports.

Changes & Results

Testing

Use a 3D viewport to test it

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 20.16.0
  • Browser: Chrome

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 0162c2d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/670fbc6ed755830008d3dfe8
😎 Deploy Preview https://deploy-preview-4424--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 0162c2d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/670fbc6e4ebc9c000871cef0
😎 Deploy Preview https://deploy-preview-4424--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salimkanoun
Copy link
Contributor

(From Pixilib team)

@sedghi sedghi merged commit d5bcf54 into OHIF:master Oct 17, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants