Comment added

ONSdigital · Sep 12, 2023 · d041eb6 · d041eb6
1 parent fd3a64a
commit d041eb6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/main-push.yaml b/.github/workflows/main-push.yaml
@@ -10,6 +10,8 @@ jobs:
       matrix:
         # Test on Windows + Ubuntu on oldest + newest supported versions of python.
         python-version: ['3.9', '3.11']
+        # Version lock pandas until v2.1.0 can be implemented without breaking Pyright - see #886
+        # pandas-version: ['pandas@latest']
         pandas-version: ['pandas~2.0']
         os: [ubuntu-latest, windows-latest]
         #including a specific test case for testing older pandas version

diff --git a/.github/workflows/pull-request.yaml b/.github/workflows/pull-request.yaml
@@ -9,7 +9,7 @@ jobs:
         # Test on linux with the newest version of python and pandas 1.x/2.x.
         python-version: ['3.11']
         os: [ubuntu-latest, windows-latest]
-        # Version lock pandas until v2.1.0 can be implemented without breaking Pyright
+        # Version lock pandas until v2.1.0 can be implemented without breaking Pyright - see #886
         # pandas-version: ['pandas@latest']
         pandas-version: ['pandas~2.0']
         include:

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -10,6 +10,8 @@ jobs:
         # Test in all supported versions of python in both Windows and Ubuntu.
         python-version: ['3.9', '3.10', '3.11']
         os: [ubuntu-latest, windows-latest]
+        # Version lock pandas until v2.1.0 can be implemented without breaking Pyright - see #886
+        # pandas-version: ['pandas@latest']
         pandas-version: ['pandas~2.0']
         #including a specific test case for testing older pandas version
         include: