-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure compatibility with python 3.10 #195
Comments
TDL:
|
Once you've set up the (probably Jenkins) script to run all of the unit/behaviour test steps, could you ensure that that you add a step to the release procedure documentation to ensure that all tests pass in all environments before completing the release. |
Jenkins file/ tox stage now starts the container from |
@CharlesRendle: pydantic have just released v1.9.0 which has python 3.10 support - I've released an updated csvcubed-version of the project with our bug fixes on top. Upgrading the version of csvcubed-pydantic in the csvcubed project should stop the errors you were seeing coming from pydantic when using python 3.10. https://pypi.org/project/csvcubed-pydantic/1.9.0/ edit: This change is now in the |
Python 3.10 has recently been released but causes some problems with our code. Unit tests are failing. We need to find out what's failing, how much of our code needs rewriting/fixing and whether that will impact on our ability to support python 3.9.
To make it clear: we want to be able to support both Python 3.9 and 3.10, so let's not start using any 3.10-specific features if we can avoid it. We might need to do some if statements/branching depending on the version of python that the tool is being run under. e.g.
Ideally, we could set up multiple docker files for 3.9/3.10 so we can test that all tests pass in both containers before publishing. This doesn't necessarily have to be part of the standard Jenkins build, but could be part of a special build process we do when releasing. We're likely to want to extend this when 3.11, etc. are released in future.
If there is little work to do, do it as part of this task, else convert this into an epic with appropriate sub-tasks.
The text was updated successfully, but these errors were encountered: