Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPARQL test Failures found on Jenkins #264

Closed
robons opened this issue Dec 10, 2021 · 0 comments
Closed

Fix SPARQL test Failures found on Jenkins #264

robons opened this issue Dec 10, 2021 · 0 comments
Assignees

Comments

@robons
Copy link
Contributor

robons commented Dec 10, 2021

After testing the Jenkins upload pipeline, I found the following SPARQL test failures. These problems will have been introduced in the outputs from csvcubed and need to be fixed there. They are sure to affect all cubes we're outputting.

The issues all result from failures to PMD test cases which is has not been possible to test against the csvcubed output due to the output not being suitable for the PMD platform.

00:02:22.903  [main] WARN uk.org.floop.sparqlTestRunner.SparqlTestRunner$ - Testcase Dimensions Exactly One Label
00:02:22.904  Expected empty result set, got:
00:02:22.904  dim,count
00:02:22.904  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/industry_code_nzsioc,0
00:02:22.904  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/variable_name,0
00:02:22.904  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/industry_code_anzsic06,0
00:02:22.904  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/year,0
00:02:22.904  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/units,0
00:02:22.904  
00:02:23.154  [main] WARN uk.org.floop.sparqlTestRunner.SparqlTestRunner$ - Testcase Dimensions Must Have Concepts In Code List
00:02:23.154  Expected empty result set, got:
00:02:23.154  dim
00:02:23.154  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/industry_code_nzsioc
00:02:23.154  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/variable_name
00:02:23.154  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/industry_code_anzsic06
00:02:23.154  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/year
00:02:23.154  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/units
00:02:23.154  
00:02:24.498  [main] WARN uk.org.floop.sparqlTestRunner.SparqlTestRunner$ - Testcase Concept Scheme Must Have Catalog Entry
00:02:24.498  Expected empty result set, got:
00:02:24.498  scheme
00:02:24.498  http://gss-data.org.uk/data/industry_code_anzsic06.csv#scheme/industry_code_anzsic06
00:02:24.498  http://gss-data.org.uk/data/industry_code_nzsioc.csv#scheme/industry_code_nzsioc
00:02:24.498  http://gss-data.org.uk/data/variable_name.csv#scheme/variable_name
00:02:24.498  http://gss-data.org.uk/data/year.csv#scheme/year
00:02:24.498  http://gss-data.org.uk/data/units.csv#scheme/units
00:02:24.498  
00:02:24.498  [main] WARN uk.org.floop.sparqlTestRunner.SparqlTestRunner$ - Testcase Concept Min One Scheme
00:02:24.498  Expected empty result set, got:
00:02:24.498  concept
00:02:24.498  http://gss-data.org.uk/data/year#concept/year/2020
00:02:24.498  http://gss-data.org.uk/data/industry_code_anzsic06#concept/industry_code_anzsic06/anzsic06-divisions-a-s-excluding-classes-k6330-l6711-o7552-o760-o771-o772-s9540-s9601-s9602-and-s9603
00:02:24.498  http://gss-data.org.uk/data/industry_code_nzsioc#concept/industry_code_nzsioc/99999
00:02:24.498  http://gss-data.org.uk/data/variable_name#concept/variable_name/total-income
00:02:24.498  http://gss-data.org.uk/data/units#concept/units/dollars-millions
00:02:24.498  http://gss-data.org.uk/data/variable_name#concept/variable_name/sales-government-funding-grants-and-subsidies
00:02:24.498  http://gss-data.org.uk/data/variable_name#concept/variable_name/interest-dividends-and-donations
00:02:24.498  http://gss-data.org.uk/data/variable_name#concept/variable_name/non-operating-income
00:02:24.498  http://gss-data.org.uk/data/variable_name#concept/variable_name/total-expenditure
00:02:24.498  http://gss-data.org.uk/data/variable_name#concept/variable_name/interest-and-donations
00:02:24.498  
00:02:26.360  [main] WARN uk.org.floop.sparqlTestRunner.SparqlTestRunner$ - Testcase Every dimension declared in a qb:DataStructureDefinition must have a declared rdfs:range.
00:02:26.360  Expected empty result set, got:
00:02:26.360  dimensionWithoutRange
00:02:26.360  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/industry_code_nzsioc
00:02:26.360  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/variable_name
00:02:26.360  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/industry_code_anzsic06
00:02:26.360  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/year
00:02:26.360  http://gss-data.org.uk/data/annual-enterprise-survey.csv#dimension/units
@robons robons self-assigned this Dec 10, 2021
robons pushed a commit that referenced this issue Dec 13, 2021
robons added a commit that referenced this issue Dec 14, 2021
@robons robons closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant