Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code List Config same_as field not serialised to CSV-W #518

Closed
GDonRanasinghe opened this issue Jun 8, 2022 · 4 comments
Closed

Code List Config same_as field not serialised to CSV-W #518

GDonRanasinghe opened this issue Jun 8, 2022 · 4 comments
Assignees
Labels
bug Something isn't working codelist

Comments

@GDonRanasinghe
Copy link
Contributor

GDonRanasinghe commented Jun 8, 2022

When the user specifies a same_as relation between a concept in their new code list and an existing concept defined elsewhere, the information is not serialised into the code list CSV-W.

We need to make sure that the same as relationship is serialised correctly into the CSV-W. This means adding the column to the CSV file as well as adding the owl:sameAs relationship to the column definition.

Refactor behave tests in cube feature.

@GDonRanasinghe GDonRanasinghe added the bug Something isn't working label Jun 8, 2022
@GDonRanasinghe GDonRanasinghe self-assigned this Jun 8, 2022
@GDonRanasinghe GDonRanasinghe changed the title Code list config does not support same as Code list config does not support same as field for concepts Jun 8, 2022
@robons robons changed the title Code list config does not support same as field for concepts Code List Config same_as field not serialised to CSV-W Jun 15, 2022
@GDonRanasinghe
Copy link
Contributor Author

@robons I've updated the effort in this ticket from 3 to 5 as this involved an additional task - refactoring behave tests in the cube feature. I have refactored all the tests in the cube feature.

@robons robons closed this as completed Jul 19, 2022
@robons
Copy link
Contributor

robons commented Oct 3, 2022

@GDonRanasinghe @canwaf has reported that this bug still exists. The same as field isn't actually being written to the CSV output file. Can you take another look fairly urgently, please?

@robons robons reopened this Oct 3, 2022
@canwaf
Copy link
Contributor

canwaf commented Oct 3, 2022

This is an example of it not serialising the same_as provided in a concept scheme. https://github.com/GSS-Cogs/family-climate-change/tree/master/datasets/Forestry-Research-Forestry-Statistics-2022-Carbon

@canwaf
Copy link
Contributor

canwaf commented Oct 4, 2022

Scoring: Impact is high: the functionality is not accessible and there is no workaround. Probability is moderate: users who want mixed-concept schemes will be impacted, which account for large number of datasets but not the majority.

This makes this bug critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codelist
Projects
None yet
Development

No branches or pull requests

4 participants