518 code list config same as field serialisation #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h concepts defined elsewhere
robons
suggested changes
Jul 5, 2022
…serted with variables instead of json object matching Updated behave tests in cube feature so that the cols and data are asserted with variables instead of json object matching
robons
suggested changes
Jul 8, 2022
| ] | ||
| """ | ||
|
|
||
| Scenario: Output a cube when an inline code list is defined using code list config schema v1.0 and when there are references to concepts defined elsewhere. |
There was a problem hiding this comment.
This one should really be asserting that the code list CSV file which has been written to disk has the same as column containing the expected values.
There was a problem hiding this comment.
@robons The cols and their content are tested in the following unit tests at test_code_list_config.py: test_code_list_config, test_code_list_config_without_schema, test_code_list_config_with_hierarchy.
@robons I have replied to your comments below outlining the unit tests as discussed. |
robons
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the implementations for supporting concepts defined elsewhere when defining a code list using code list config.
Satisfied #518