Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#62 Test cube validation #111

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Issue#62 Test cube validation #111

merged 3 commits into from
Jul 29, 2021

Conversation

santhosh-thangavel
Copy link
Contributor

Suitable error message is generated when

  1. A cube with two columns with the same title is defined.
  2. Defining a column with a title that doesn't exist in the DataFrame.
  3. A column in input DataFrame doesn't have a column mapping.

#62

@santhosh-thangavel
1.If a cube with two columns with the same title is defined, suitable…
4651c2f 
… error message is generated.

2.A suitable error is generated when a column title in a cube is not defined in CSV data.
3.A suitable error message is generated when a CSV data contains a column which is not defined.
2.csv_column_title is added to existing column titles.
@santhosh-thangavel
1.If a cube with two columns with the same title is defined, suitable…
446db83 
… error message is generated.

2.A suitable error is generated when a column title in a cube is not defined in CSV data.
3.A suitable error message is generated when a CSV data contains a column which is not defined.
2.csv_column_title is added to existing column titles.
@santhosh-thangavel
1.Refactored the code.
3193796
@santhosh-thangavel
Copy link
Contributor Author

@canwaf please, review my PR.

@canwaf canwaf self-requested a review July 29, 2021 09:53
canwaf
canwaf approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@canwaf canwaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approve these changes; however there is potential for a bug not in your implementation but in the surrounding code. I'll raise an issue separately.

@santhosh-thangavel santhosh-thangavel merged commit 727c8e7 into main Jul 29, 2021
@santhosh-thangavel santhosh-thangavel deleted the santhosh/issue62 branch July 29, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canwaf canwaf canwaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santhosh-thangavel @canwaf