-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #71 - Allow Relating units together with Multipliers #146
Conversation
… existing one with a multiplication factor relating the two.
I don't see that we need to choose between OM2 and QUDT, it seems reasonable we could make use of both. For units like How would a user specify something like "megalitres per day"? |
I'm not entirely sure what you're suggesting here... I think we are using both.
I think if we take this approach we might want to take a more organised and systematic approach to the QUDT ontology and ensure we define all the related
i think they'd base it off the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santhosh-thangavel and I have worked through the changes made by this PR and have come up with some questions regarding the gaps in our combined knowledge.
@ Rob, Thanks for the answers. |
Cheers @robons, would be good to get |
…nd dependency) as a result of PR comments.
@rossbowen I've added the qudt:conversionMultiplier functionality there. I've made it codependent on providing the quantity kind that the unit is part of since the Happy with the changes? |
This PR serves to close Issue #71.
However, instead of allowing the user to specify a multiplier against each observations, we are allowing the user to define a new unit which is related to an existing one by a multiplying factor. This has the same effect of allowing us to define the inter-relationships between units which vary only by their magnitude.
See here for an example of how the new units can be defined relative to existing units.
See here for an example of the RDF which is output.
Uses some qudt along with the om2 ontology since the qudt ontology itself isn't sufficient to specify the multiplying factor relationship between two units in a low-maintenance way.