Issue-68 Behaviour test info.json config.loader #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.Cube&qb validation succeeds. 3.Cube is serialised to CSV-W 4.csvlint validation succeeds 5.csv2rdf succeeds 6.RDF passes "SKOS, qb" SPARQL tests 7.Ouput ttl is compared with ttl as we do in gss-utils 8.Additional ttl is appended to the resulting RDF for multi-measure-data.csv as the Measure dimension and unit attribute defined in info.json is an existing dimension and attribute.
|
@canwaf Please, review my pull request. |
canwaf
approved these changes
Sep 7, 2021
robons
reviewed
Sep 8, 2021
| @@ -67,7 +67,7 @@ def test_structure_defined(): | |||
| "Observed Value", | |||
| QbSingleMeasureObservationValue( | |||
| ExistingQbMeasure("http://example.org/units/some-existing-measure"), | |||
| ExistingQbUnit("http://example.org/units/some-existing-unit"), | |||
| ExistingQbUnit("http://example.org/units/some-exisiting-unit"), | |||
There was a problem hiding this comment.
You've typoed my good spelling? :P
There was a problem hiding this comment.
@robons Fixed it. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.A cube is loaded using the info.json with a CSV.
2.Cube&qb validation succeeds.
3.Cube is serialised to CSV-W
4.csvlint validation succeeds
5.csv2rdf succeeds
6.RDF passes "SKOS, qb" SPARQL tests
7.Ouput ttl is compared with ttl as we do in gss-utils
8.Additional ttl is appended to the resulting RDF for multi-measure-data.csv as the Measure dimension and unit attribute defined in info.json is an existing dimension and attribute.
#68