Issue #28 - Allowing CatalogMetadata Serialisation/Deserialisation to/from JSON #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 10, 2021 08:56
… dataclassbase.py.
Also testing that catalog metadata can easily be serialised to/deserialised from JSON.
added 11 commits
September 10, 2021 15:08
canwaf
approved these changes
Sep 13, 2021
| "Location of a JSON file containing the Catalog Metadata for this qube. " | ||
| "If present, this overrides any configuration found in the info.json." | ||
| ), | ||
| type=click.Path(exists=True, path_type=Path, file_okay=True, dir_okay=False), |
There was a problem hiding this comment.
This is one for the documentation on the series of overrides.
- Catalog information from
info.json - Catalog information from scraper
- Catalog information from
catalog-metadata.json - Runtime changes
| @@ -33,34 +34,9 @@ | |||
| T = TypeVar("T", bound=object) | |||
|
|
|||
|
|
|||
| def _from_dict(cls: Type[T], d: dict) -> T: | |||
There was a problem hiding this comment.
I found where all the lines where dropped. :D
| json.dump(self.as_json_dict(), f, indent=4) | ||
|
|
||
| @classmethod | ||
| def from_json_file(cls, file_path: Path) -> "CatalogMetadata": |
robons
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Issue #28.