Canwaf/issue13 #219
Merged
Canwaf/issue13 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work started on #13
* poetry locked * readme updated (including new issue) * imports in package: qb.py, skos.py * imports in tests: test_dataclassbase.py, test_resource_serialisation.py
* README.md changes * Packages now reference correct packages
* relocked poetry.lock * pyproject.toml changes * devtools now propertly referenced * models now properly referenced * README.md updated package name * imports fixed (many many files) * test changes to account for new package layout * unit tests working * behaviour tests failing on devtools impots
* locked * devtools repointed * imports fixed * behave step files must not have test_ prefix (that's unit testing) * behave tests otherwise fixed
* csvcubed - devtools README.md * docs - developer.md (package name changes, style)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@canwaf, please address comments on the old PR before merging this one. Once you've addressed the comments, feel free to go ahead with this.