-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
294 define codelist in qubeconfig #460
Conversation
code list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bit more work which needs doing to this to get it ready for coding; think of how we would follow a predictable "configuration by convention" approach as we have done with cube configs.
csvcubed/csvcubed/schema/codelist-config/v1_0/codelistconfig-example.jsonc
Outdated
Show resolved
Hide resolved
…ce of parent notation lookup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty close to being done.
If you could change the schema a little or use enums in the sort object as well as changing the underlying behaviour of the sort functionality then that would make it great.
@robons Sure, I will do these updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. So long as you add some tests for the sort_order logic, you're good to go.
@robons This is also done now. |
This PR involves extending the qube config so that the users can define code lists within the qube config file.
The following tasks are ready for review:
schema/codelist-config/v1_0/codelistconfig-example.jsonc
file).schema/codelist-config/v1_0/schema.json
file).Satisfies #294