Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new templates #726

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Adding new templates #726

merged 3 commits into from
Feb 13, 2023

Conversation

SarahJohnsonONS
Copy link
Contributor

Adding new templates

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

ubuntu-latest-python3.9 test results

449 tests  ±0   449 ✔️ ±0   3m 22s ⏱️ - 1m 24s
    8 suites ±0       0 💤 ±0 
    8 files   ±0       0 ±0 

Results for commit 50ceb88. ± Comparison against base commit 7539ef0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

ubuntu-latest-python3.11 test results

449 tests  ±0   449 ✔️ ±0   3m 30s ⏱️ - 1m 34s
    8 suites ±0       0 💤 ±0 
    8 files   ±0       0 ±0 

Results for commit 50ceb88. ± Comparison against base commit 7539ef0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

windows-latest-python3.11 test results

    9 files  ±0    10 suites  ±0   9m 0s ⏱️ -14s
463 tests ±0  463 ✔️ ±0  0 💤 ±0  0 ±0 
476 runs  ±0  476 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 50ceb88. ± Comparison against base commit 7539ef0.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@robons robons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fundamentally looks good, but take another look at the description field before merging.

"cell_uri_template": "http://reference.data.gov.uk/id/government-year/{+<column_name>}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

"type": "dimension",
"from_existing": "http://purl.org/linked-data/sdmx/2009/dimension#refPeriod",
"label": "Mixed Time Period",
"description": "Template allowing the use of different time periods within one dimension, e.g. 2020-Q4 (quarter), 2021-06 (month), 2019-08-06 (day)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description describes the dimension, not the template. So I'd reword it if you could.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, amended

@@ -677,7 +677,10 @@
"government-half-year",
"government-quarter",
"government-week",
"gregorian-instant"
"mixed-period",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd forgotten about this, nice catch.

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SarahJohnsonONS SarahJohnsonONS marked this pull request as ready for review February 13, 2023 09:26
@SarahJohnsonONS SarahJohnsonONS merged commit 14f2c3d into main Feb 13, 2023
@robons robons deleted the 719-new-templates branch February 13, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants