-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new templates #726
Adding new templates #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fundamentally looks good, but take another look at the description
field before merging.
"cell_uri_template": "http://reference.data.gov.uk/id/government-year/{+<column_name>}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
"type": "dimension", | ||
"from_existing": "http://purl.org/linked-data/sdmx/2009/dimension#refPeriod", | ||
"label": "Mixed Time Period", | ||
"description": "Template allowing the use of different time periods within one dimension, e.g. 2020-Q4 (quarter), 2021-06 (month), 2019-08-06 (day)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description
describes the dimension, not the template. So I'd reword it if you could.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, amended
@@ -677,7 +677,10 @@ | |||
"government-half-year", | |||
"government-quarter", | |||
"government-week", | |||
"gregorian-instant" | |||
"mixed-period", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd forgotten about this, nice catch.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Adding new templates