#755 FIX unit component duplication BUG #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickPapONS
reviewed
Mar 8, 2023
robons
reviewed
Mar 9, 2023
| ) -> List[rdf.qb.AttributeComponentSpecification]: | ||
| if self._units_component_already_defined: | ||
| # Don't define a second units component, the first one will work just fine. | ||
| return [] |
There was a problem hiding this comment.
Can you add some debug logging here so we can track that we're avoiding serialising a second units component?
There was a problem hiding this comment.
self, column_name_uri_safe: str
) -> List[rdf.qb.AttributeComponentSpecification]:
if self._units_component_already_defined:
_logger.debug(
"The component type has already been serialised, %s.",
column_name_uri_safe,
)
# Don't define a second units component, the first one will work just fine.
return []```
is this the right place for it?
There was a problem hiding this comment.
that's definitely the right place, but could it say something like Units component already generated. Not generating a second one.
There was a problem hiding this comment.
Yeah cool I'll sort it out
robons
reviewed
Mar 9, 2023
|
Kudos, SonarCloud Quality Gate passed! |
robons
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#755 Bug was noticed during the work on #703.