Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#703 Inspect API - Listing columns with their types. #761

Merged
merged 26 commits into from
Mar 20, 2023
Merged

#703 Inspect API - Listing columns with their types. #761

merged 26 commits into from
Mar 20, 2023

Conversation

nimshi89
Copy link
Contributor

@nimshi89 nimshi89 commented Mar 10, 2023 •
edited
Loading

#703 This ticket adds Api function to the DataCubeInspector class for mapping between CSV Columns.

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

ubuntu-latest-python3.11 test results

523 tests   523 ✔️  3m 24s ⏱️
    9 suites      0 💤
    9 files        0 ❌

Results for commit da56b29.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

ubuntu-latest-python3.9 test results

523 tests   523 ✔️  3m 4s ⏱️
    9 suites      0 💤
    9 files        0 ❌

Results for commit da56b29.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

windows-latest-python3.11 test results

  10 files    11 suites   8m 26s ⏱️
537 tests 537 ✔️ 0 💤 0 ❌
550 runs  550 ✔️ 0 💤 0 ❌

Results for commit da56b29.

♻️ This comment has been updated with latest results.

@nimshi89 nimshi89 marked this pull request as ready for review March 16, 2023 12:52
robons
robons reviewed Mar 17, 2023
View reviewed changes
Output.txt Outdated Show resolved Hide resolved
external-docs/docs/quick-start/inspect.md Outdated Show resolved Hide resolved
external-docs/docs/quick-start/inspect.md Outdated Show resolved Hide resolved
src/csvcubed/cli/inspect/inspect.py Outdated Show resolved Hide resolved
src/csvcubed/cli/inspect/inspect.py Show resolved Hide resolved
tests/behaviour/inspectcli.feature Outdated Show resolved Hide resolved
tests/unit/cli/inspect/test_metadataprinter.py Outdated Show resolved Hide resolved
tests/unit/cli/inspect/test_metadataprinter.py Outdated Show resolved Hide resolved
tests/unit/utils/sparqlhandler/test_csvw_inspector.py Outdated Show resolved Hide resolved
tests/unit/utils/sparqlhandler/test_data_cube_inspector.py Outdated Show resolved Hide resolved
@robons robons changed the title #703 map between csv columns #703 Inspect API - Listing columns with their types. Mar 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

CharlesRendle
CharlesRendle approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@CharlesRendle CharlesRendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the code and all changes have been addressed.
Happy tests all passing.

Approving for merge - only change would be to the name result_column_component_infos

What's wrong with just result_column_component_info
or
column_component_info_results?

@robons robons merged commit 130719a into main Mar 20, 2023
@robons robons deleted the #703-map-between-CSV-columns branch March 20, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robons robons robons left review comments

@CharlesRendle CharlesRendle CharlesRendle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nimshi89 @CharlesRendle @robons