New attribute literal label set as Optional
#766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Happy that this change satisfies the ticket.
Have verified that the column name is used for label property when building a csvw
And it looks like the documentation portion has been addressed in ticket #520
Approving, but worth thinking if this needs a unit test to demonstrate what the problem is/was and the functionality now expected under the bug conditions. E.g.
When an attribute column is defined:
"columns": {
"My New Attribute Literal": {
"type": "Attribute",
"data_type": "decimal",
}
}
The metadata.json file should contain:
"http://www.w3.org/2000/01/rdf-schema#label": [
{
"@language": "en",
"@value": "Attribute"
}
],
@robons given it's such a small change, what do you think?
CharlesRendle
suggested changes
Mar 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
CharlesRendle
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix - changed NewAttributeLiteral
labelto Optional[str] - iflabelnot provided, it defaults to the column title.