Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#769 Fixing bug when inspecting code-lists #771

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

robons
Copy link
Contributor

@robons robons commented Apr 3, 2023

Fixing issue introduced in previous release where code-list inspect would fail.

Satisfies issue #769.

Fixing issue introduced in previous release where code-list inspect would fail.
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

ubuntu-latest-python3.11 test results

529 tests  +2   529 ✔️ +2   3m 7s ⏱️ ±0s
    9 suites ±0       0 💤 ±0 
    9 files   ±0       0 ±0 

Results for commit 7fdbe58. ± Comparison against base commit 6e985ce.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

ubuntu-latest-python3.9 test results

529 tests  +2   529 ✔️ +2   3m 37s ⏱️ +9s
    9 suites ±0       0 💤 ±0 
    9 files   ±0       0 ±0 

Results for commit 7fdbe58. ± Comparison against base commit 6e985ce.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@CharlesRendle CharlesRendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy this change fixes the issue. Glad to see a test added for inspecting a code list end-to-end too.
Approved.

Copy link
Contributor

@CharlesRendle CharlesRendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes as ive just seen the build fail

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

windows-latest-python3.11 test results

  10 files  ±0    11 suites  ±0   7m 7s ⏱️ +17s
543 tests +2  543 ✔️ +2  0 💤 ±0  0 ±0 
556 runs  +2  556 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 7fdbe58. ± Comparison against base commit 6e985ce.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@robons robons dismissed CharlesRendle’s stale review April 3, 2023 13:11

Overriding so I can get this released.

@robons robons merged commit c9e48f8 into main Apr 3, 2023
@robons robons deleted the robons-769-fix-code-list-inspect branch April 3, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants