Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logger strings with identifying information #899

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

SarahJohnsonONS
Copy link
Contributor

Added identifying information (e.g. column title) to logger messages.

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

ubuntu-latest-python3.9- test results

  10 files    10 suites   6m 5s ⏱️
589 tests 589 ✔️ 0 💤 0
590 runs  590 ✔️ 0 💤 0

Results for commit 5e5bd59.

@github-actions
Copy link

ubuntu-latest-python3.11-pandas~2.0 test results

  10 files  +  5    10 suites  +5   6m 53s ⏱️ + 5m 12s
589 tests +72  589 ✔️ +72  0 💤 ±0  0 ±0 
590 runs  +73  590 ✔️ +73  0 💤 ±0  0 ±0 

Results for commit 5e5bd59. ± Comparison against base commit 01489db.

@github-actions
Copy link

windows-latest-python3.11-pandas~2.0 test results

  11 files  +  11    12 suites  +12   8m 2s ⏱️ + 8m 2s
603 tests +603  603 ✔️ +603  0 💤 ±0  0 ±0 
617 runs  +617  617 ✔️ +617  0 💤 ±0  0 ±0 

Results for commit 5e5bd59. ± Comparison against base commit 01489db.

@github-actions
Copy link

ubuntu-latest-python3.11-pandas@^1.3 test results

547 tests  +9   547 ✔️ +9   2m 37s ⏱️ +19s
    8 suites +1       0 💤 ±0 
    8 files   +1       0 ±0 

Results for commit 5e5bd59. ± Comparison against base commit 01489db.

Copy link
Contributor

@NickPapONS NickPapONS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. A lot more logger changes than I expected! Well done

@NickPapONS NickPapONS merged commit 50855b4 into main Oct 13, 2023
17 of 19 checks passed
@NickPapONS NickPapONS deleted the #874-Include-column-title-in-logger-messages branch October 13, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants