Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aboutUrl function #98

Merged
merged 7 commits into from
Jul 28, 2021
Merged

aboutUrl function #98

merged 7 commits into from
Jul 28, 2021

Conversation

CharlesRendle
Copy link
Contributor

aboutUrl function which places multimeasure dimensions at the end of the URL with two accompanying unit tests.

Have added a todo regarding a future least -> most entropic dimension ordering approach.

@CharlesRendle
Copy link
Contributor Author

All changes made based on PR comments

Copy link
Contributor

@robons robons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just need to fix your file conflicts before merging.

Copy link
Contributor

@canwaf canwaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking review for now.

@canwaf
Copy link
Contributor

canwaf commented Jul 27, 2021

Happy to see this merged now.

@CharlesRendle CharlesRendle merged commit d219668 into main Jul 28, 2021
@CharlesRendle CharlesRendle deleted the CharlesR/aboutUrl branch July 28, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants