-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aboutUrl function #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the URL with two accompanying unit tests.
robons
reviewed
Jul 21, 2021
robons
reviewed
Jul 21, 2021
robons
reviewed
Jul 21, 2021
robons
reviewed
Jul 21, 2021
robons
reviewed
Jul 21, 2021
All changes made based on PR comments |
robons
reviewed
Jul 23, 2021
robons
reviewed
Jul 23, 2021
robons
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just need to fix your file conflicts before merging.
CharlesRendle
force-pushed
the
CharlesR/aboutUrl
branch
from
July 27, 2021 10:25
742de9c
to
e9826ce
Compare
robons
reviewed
Jul 27, 2021
canwaf
suggested changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking review for now.
canwaf
approved these changes
Jul 27, 2021
Happy to see this merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aboutUrl function which places multimeasure dimensions at the end of the URL with two accompanying unit tests.
Have added a todo regarding a future least -> most entropic dimension ordering approach.