Default min number of ECS Service container tasks to 1 for developers #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonnyshaw89 is there a reason we're currently tied to v1.0.0 for eq-ecs-deploy? |
|
@dwyeradam just so it’s tied to a release version. You can create a new release version and point to that |
jonnyshaw89
suggested changes
Feb 19, 2018
developer_defaults.tf
Outdated
| @@ -290,6 +295,11 @@ variable "survey_launcher_jwt_signing_key_path" { | |||
| default = "jwt-test-keys/sdc-user-authentication-signing-rrm-private-key.pem" | |||
| } | |||
|
|
|||
| variable "application_min_tasks" { | |||
There was a problem hiding this comment.
We shouldn't reuse this variable, we should have one for each service.
jonnyshaw89
approved these changes
Feb 19, 2018
dwyeradam
force-pushed
the
eq-1835-default-minimum-number-of-ecs-service-containers
branch
from
539fd43
to
72eeb8c
Compare
jonnyshaw89
deleted the
eq-1835-default-minimum-number-of-ecs-service-containers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To override for developer environments the defaults defined by the following PRs:
ONSdigital/eq-ecs-deploy#8
ONSdigital/eq-author-deploy#10
ONSdigital/eq-survey-runner-deploy#17