Fix freed memory use in tee_session_close_and_destroy() #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -392,7 +392,7 @@ int tee_session_close_and_destroy(struct tee_session *sess) | |||
| devm_kfree(_DEV(tee), sess); | |||
| tee_context_put(ctx); | |||
| tee_put(tee); | |||
| mutex_unlock(&sess->ctx->tee->lock); | |||
| mutex_unlock(&tee->lock); | |||
There was a problem hiding this comment.
The argument for mutex_lock() above should also be &tee->lock for easier matching.
|
Updated |
|
|
The following code is wrong as shm->tee is unpredictable
because of the former free():
devm_kfree(_DEV(tee), sess);
[...]
mutex_unlock(&sess->ctx->tee->lock);
It is fixed in
devm_kfree(_DEV(tee), sess);
[...]
mutex_unlock(&tee->lock);
Reviewed-by: Jens Wiklander <[email protected]>
Signed-off-by: Pascal Brand <[email protected]>
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code is wrong as shm->tee is unpredictable
because of the former free():
devm_kfree(_DEV(tee), sess);
[...]
mutex_unlock(&sess->ctx->tee->lock);
It is fixed in
tee_shm_free(shm);
devm_kfree(_DEV(tee), sess);
[...]
mutex_unlock(&tee->lock);
Signed-off-by: Pascal Brand [email protected]