Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: demote a couple of messages from IMSG() to DMSG() #1645

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

jforissier
Copy link
Contributor

The first and and fourth lines in the boot sequence below are debug
messages that should not be printed when the log level is INFO:

INFO: TEE-CORE: No NSEC DDR memory area defined
INFO: TEE-CORE:
INFO: TEE-CORE: OP-TEE version: 2.5.0-rc1 #1 Wed Jun 28 15:11:06 UTC 2017 aarch64
INFO: TEE-CORE: Shared memory address range: 3dc00000, 3f000000
INFO: TEE-CORE: Initialized

Signed-off-by: Jerome Forissier [email protected]

@etienne-lms
Copy link
Contributor

Can we also remove the empty line INFO message (https://github.com/OP-TEE/optee_os/blob/master/core/arch/arm/kernel/generic_boot.c#L230). What do you think? I find it a bit ugly.

@etienne-lms
Copy link
Contributor

Sorry, I forgot something: for current P-R:
Reviewed-by: Etienne Carriere <[email protected]>

@jforissier
Copy link
Contributor Author

Can we also remove the empty line INFO message (https://github.com/OP-TEE/optee_os/blob/master/core/arch/arm/kernel/generic_boot.c#L230). What do you think? I find it a bit ugly.

No, it was added on purpose: afd58d7 ("Add one IMSG line before OP-TEE init message").

The first and and fourth lines in the boot sequence below are debug
messages that should not be printed when the log level is INFO:

 INFO:    TEE-CORE: No NSEC DDR memory area defined
 INFO:    TEE-CORE:
 INFO:    TEE-CORE: OP-TEE version: 2.5.0-rc1 #1 Wed Jun 28 15:11:06 UTC 2017 aarch64
 INFO:    TEE-CORE: Shared memory address range: 3dc00000, 3f000000
 INFO:    TEE-CORE: Initialized

Signed-off-by: Jerome Forissier <[email protected]>
Reviewed-by: Etienne Carriere <[email protected]>
@etienne-lms
Copy link
Contributor

Ok, thanks for the link. Clear.
Instead, I think the hikey platform could:

--- a/core/arch/arm/plat-hikey/main.c
+++ b/core/arch/arm/plat-hikey/main.c
@@ -85,6 +85,9 @@ void console_init(void)
 	pl011_init(&console_data, CONSOLE_UART_BASE, CONSOLE_UART_CLK_IN_HZ,
 		   CONSOLE_BAUDRATE);
 	register_serial_console(&console_data.chip);
+
+	/* flush earlier boot stage traces from current console line */
+	console_putc('\n');
 }
 
 vaddr_t nsec_periph_base(paddr_t pa)

Even proposal approved, maybe after 2.5.0. No hurry.

@jforissier jforissier deleted the dmsg branch November 13, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants