make clean: split file list into manageable chunks #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk/cleandirs.mk
Outdated
| # (200 files at a time), to minimize the odds of having: | ||
| # "/bin/bash: Argument list too long" | ||
| define do-rm-f | ||
| $(call _do-rm, $(wordlist 1, 200, $(1))) |
There was a problem hiding this comment.
Doh! That's what happens when you decide to rename something at the last minute.
Will fix, thanks.
etienne-lms
reviewed
Oct 25, 2017
mk/cleandirs.mk
Outdated
|
|
||
| define _do-rm-f | ||
| ${q}rm -f $1 | ||
|
|
There was a problem hiding this comment.
minor: spurious empty line
There was a problem hiding this comment.
Correct. Leftover from a previous solution whic hwas simply iterating with foreach.
Will fix.
mk/cleandirs.mk
Outdated
| $(call _do-rm, $(wordlist 1, 200, $(1))) | ||
| $(eval _tail := $(wordlist 201, $(words $(1)), $(1))) | ||
| $(if $(_tail), $(call do-rm-f, $(_tail))) | ||
| $(eval _tail :=) |
There was a problem hiding this comment.
No, un-necessary cleanup indeed. Will fix.
mk/cleandirs.mk
Outdated
| # (200 files at a time), to minimize the odds of having: | ||
| # "/bin/bash: Argument list too long" | ||
| define do-rm-f | ||
| $(call _do-rm, $(wordlist 1, 200, $(1))) |
|
Update |
|
|
"make clean" might fail with the following error: make[2]: execvp: /bin/bash: Argument list too long This error was observed on a platform that has lots of additional source files compared to upstream (drivers, etc.), and that sets a long output path on the command line (make ... O=/some/long/path). Fix the error by splitting the file list into more manageable chunks. Note that removing one file at a time is not reasonable, because spawning too may shells takes quite a long time (up to 7-10 seconds to "make clean"). Signed-off-by: Jerome Forissier <[email protected]> Reported-by: Lijianhui <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
jforissier
force-pushed
the
clean-huge-file-list
branch
from
fd97054
to
4b358a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"make clean" might fail with the following error:
make[2]: execvp: /bin/bash: Argument list too long
This error was observed on a platform that has lots of additional
source files compared to upstream (drivers, etc.), and that sets a long
output path on the command line (make ... O=/some/long/path).
Fix the error by splitting the file list into more manageable chunks.
Note that removing one file at a time is not reasonable, because
spawning too may shells takes quite a long time (up to 7-10 seconds to
"make clean").
Signed-off-by: Jerome Forissier [email protected]
Reported-by: Lijianhui [email protected]