Replace struct prng_ops with function interface #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Nov 8, 2017
There was a problem hiding this comment.
Reviewed-by: Etienne Carriere <[email protected]> with minor fixes.
core/include/tee/tee_cryp_provider.h
Outdated
| TEE_Result rng_generate(void *buffer, size_t len); | ||
|
|
||
|
|
||
|
|
core/include/tee/tee_cryp_provider.h
Outdated
| @@ -314,6 +305,15 @@ extern const struct crypto_ops crypto_ops; | |||
| TEE_Result hash_sha256_check(const uint8_t *hash, const uint8_t *data, | |||
| size_t data_size); | |||
|
|
|||
|
|
|||
| /* add entropy to PRNG entropy pool */ | |||
There was a problem hiding this comment.
minor: can you capitalize first character for consistency with other comments?
core/include/tee/tee_cryp_provider.h
Outdated
| /* add entropy to PRNG entropy pool */ | ||
| TEE_Result crypto_rng_add_entropy(const uint8_t *inbuf, size_t len); | ||
|
|
||
| /* to read random data from PRNG implementation */ |
There was a problem hiding this comment.
minor: can you capitalize first character for consistency with other comments and remove trailing spaces?
Adds crypto_rng_add_entropy() and crypto_rng_read() replacing struct prng_ops in crypto_ops. Reviewed-by: Etienne Carriere <[email protected]> Tested-by: Jens Wiklander <[email protected]> (QEMU) Signed-off-by: Jens Wiklander <[email protected]>
jenswi-linaro
force-pushed
the
crypto_ops
branch
from
3577f90
to
ba4a0c4
Compare
|
Comments addressed, tag applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds crypto_rng_add_entropy() and crypto_rng_read() replacing
struct prng_ops in crypto_ops.
Tested-by: Jens Wiklander [email protected] (QEMU)
Signed-off-by: Jens Wiklander [email protected]
It turns out that #1912 wasn't enough for #1856 to be compiled with
With this PR the init size becomes more reasonable.