Avoid the potential memory leak after early return. #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Nov 22, 2017
There was a problem hiding this comment.
Thanks for the patch.
Please add a Signed-off-by: tag (see https://github.com/OP-TEE/optee_os/blob/master/documentation/github.md#contributing-1).
You can also add my:
Reviewed-by: Jerome Forissier <[email protected]>
Last thing: I'd rather not mention the issue ID in the subject but rather in the commit log as a Fixes: tag.
To be clear, here is how I'd like it to look like:
tee_fs_rpc_opendir(): avoid potential memory leak after early return
Fixes: https://github.com/OP-TEE/optee_os/issues/1960
Signed-off-by: ...your name and email here...
Reviewed-by: Jerome Forissier <[email protected]>
core/tee/tee_fs_rpc.c
Outdated
| return res; | ||
|
|
||
| goto err_exit; | ||
There was a problem hiding this comment.
Extra tab, not needed. Please remove.
viennadd
changed the title
viennadd
force-pushed
the
master
branch
2 times, most recently
from
b3b0a4d
to
989d95a
Compare
|
|
Fixes: OP-TEE#1960 Signed-off-by: Alex CHEN <[email protected]> Reviewed-by: Jerome Forissier <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1960