poplar: Add initial support #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prime-zeng fyi |
core/arch/arm/plat-poplar/main.c
Outdated
| @@ -0,0 +1,59 @@ | |||
| /* | |||
| * Copyright (c) 2017, Linaro Limited | |||
| * All rights reserved. | |||
There was a problem hiding this comment.
We don't the "All rights reserved" line any longer, please remove it in the other files added with Linaro copyright.
There was a problem hiding this comment.
Removed in all related files. Thanks for the link!
| #define STACK_ALIGNMENT 64 | ||
|
|
||
| /* PL011 UART */ | ||
| #define CONSOLE_UART_BASE PL011_UART0_BASE |
There was a problem hiding this comment.
A define from hi3798cv200.h is used here, please include the file too.
There was a problem hiding this comment.
Ah, it was in main.c. Will remove it there and include it here instead. Thanks for spotting!
|
All comment addressed. Please continue review. Thanks! |
|
|
vchong
force-pushed
the
poplar_hisi_review2
branch
from
2645818
to
6c68d84
Compare
|
Rebased, squashed and tag added. Ok to merge? Thanks! |
Signed-off-by: Victor Chong <[email protected]> Acked-by: Jens Wiklander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Victor Chong [email protected]