core: fix offset in assign_mobj_to_param_mem() #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you expect this should fix #2414? It certainly looks like it does :) |
|
Hm, I wonder how it worked prior to this fix... I certainly had issues with offsets when I worked on non-contig buffers. And at that time I had to use offset. Looks like something have changed later. |
|
This part of the code is never triggered with the Linux driver, but I can't recall why at the moment. I was discovering this while hacking on TEE Client implementation for U-boot. I don't expect it to fix #2414. |
|
Ah, yes, right. I played with non-contig buffers a long ago. Maybe I missed this issue then. Anyways, it looks like right fix.
|
Prior to this patch assign_mobj_to_param_mem() stored the offset supplied with a non-contiguous buffer in mem->offs. Since that offset already is stored inside the resulting MOBJ that offset is added twice. This patch fixes this by initializing mem->offs to 0 instead. Reviewed-by: Volodymyr Babchuk <[email protected]> Signed-off-by: Jens Wiklander <[email protected]>
jenswi-linaro
force-pushed
the
noncontig_fix
branch
from
28587d6
to
3d3c378
Compare
|
Tag applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch assign_mobj_to_param_mem() stored the offset
supplied with a non-contiguous buffer in mem->offs. Since that offset
already is stored inside the resulting MOBJ that offset is added twice.
This patch fixes this by initializing mem->offs to 0 instead.
Signed-off-by: Jens Wiklander [email protected]