Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic fixes for build output #33

Merged
1 commit merged into from
Sep 2, 2014
Merged

Cosmetic fixes for build output #33

1 commit merged into from
Sep 2, 2014

Conversation

jforissier
Copy link
Contributor

By default, the OP-TEE build shows abbreviated output similar to the Linux
kernel. This commit fixes a number of deviations/inconsistencies.

  • Always print a command in uppercase, followed by the target file.
  • Make sure commands and file paths are nicely aligned, with two leading spaces
    to make command output/errors better stand out.
  • Remove some duplicate slashes in file paths. We use the following rule:
    variables that hold directory names such as $(arch-dir) or $(platform-dir)
    always have a trailing slash. The 'subdirs' and 'incdirs' variables used in
    sub-makefiles are an exception because doing otherwise would needlessly
    clutter the sub-makefiles.

@jbech-linaro
Copy link
Contributor

+1, I like this a lot (been thinking about doing similar changes also). The only thing that nags me is that we loose the / after $(platform-dir) and friends in the actual makefiles. Sure there shouldn't be double slashes when compiling, so this is better. But I think I'd prefer that $(platform-dir) and friends don't have trailing slash. But hey, this is just a minor comment from my side, so I don't argue against merging this patch. So again +1.

@jforissier
Copy link
Contributor Author

Well, the reason why I chose to keep the trailing slash in the variable is that the $(dir...) function always returns a string terminated with a slash. So, you would have to use $(patsubst %/,%, $(dir ...)) every time you want to extract a directory name from a path.

@jenswi-linaro
Copy link
Contributor

+1

@pascal-brand38
Copy link
Contributor

+1
Please squash on top of master

By default, the OP-TEE build shows abbreviated output similar to the Linux
kernel. This commit fixes a number of deviations/inconsistencies.

- Always print a command in uppercase, followed by the target file.
- Make sure commands and file paths are nicely aligned, with two leading spaces
to make command output/errors better stand out.
- Remove some duplicate slashes in file paths. We use the following rule:
variables that hold directory names such as $(arch-dir) or $(platform-dir)
always have a trailing slash. The 'subdirs' and 'incdirs' variables used in
sub-makefiles are an exception because doing otherwise would needlessly
clutter the sub-makefiles.
@jforissier
Copy link
Contributor Author

Rebased.

@ghost ghost merged commit 0047cb6 into OP-TEE:master Sep 2, 2014
@yilingxu yilingxu mentioned this pull request Apr 1, 2018
sahilnxp added a commit to sahilnxp/optee_os that referenced this pull request Oct 5, 2020
…:optee_os_3.8.0 to optee_os_3.8.0

* commit '9dd1e2b34cb57c25d8bda853f145fb1cf2aede74':
  plat-ls: add i2c driver for NXP LS Platforms
CyanDevs pushed a commit to CyanDevs/optee_os that referenced this pull request Jan 23, 2023
plat-imx: fix reboot on mx7dsabresd and mx7dclsom
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants