Move inject_entropy_with_timestamp() inside mutex protected sections #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inject_entropy_with_timestamp() is used to change the entropy of the RNG each time we call tee_dispatch_open_session / tee_dispatch_close_session. This is performed outside of a session context, and outside mutex protection. inject_entropy_with_timestamp() calls RPC to get the REE time. When freing the shared memory in case of concurrent TA, we may have a race condition between optee_os and the supplicant when accessing / freeing the shared memory. This patch calls inject_entropy_with_timestamp() inside the mutex protected section, when calling tee_ta_init_session(). Signed-off-by: Pascal Brand <[email protected]>
Closed
|
In |
|
Right. Correct fix is OP-TEE/optee_linuxdriver#37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inject_entropy_with_timestamp() is used to change the
entropy of the RNG each time we call tee_dispatch_open_session /
tee_dispatch_close_session. This is performed outside of a
session context, and outside mutex protection.
inject_entropy_with_timestamp() calls RPC to get the REE time.
When freing the shared memory in case of concurrent TA, we may
have a race condition between optee_os and the supplicant
when accessing / freeing the shared memory.
This patch calls inject_entropy_with_timestamp() inside the
mutex protected section, when calling tee_ta_init_session().
Signed-off-by: Pascal Brand [email protected]