Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "#2656 Fix for - Session is not provided by ClearChangeMasks w… #2792

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Oct 11, 2024

Proposed changes

…hen a change is notified (#2772)"
This reverts commit 9c7b321.

During tests the new code ran into an ArgumentNullException creating a new OperationContext.
Even with more checks I have performance concerns about the copy of the servicecontext and the new OperationContext for every data change, it may affect the server perf. We need to find a better solution.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

…hen a change is notified (#2772)"

This reverts commit 9c7b321.
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.93%. Comparing base (9c7b321) to head (492f2b2).

Files with missing lines Patch % Lines
...braries/Opc.Ua.Server/Diagnostics/MonitoredNode.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   55.40%   54.93%   -0.48%     
==========================================
  Files         349      349              
  Lines       66055    66049       -6     
  Branches    13549    13547       -2     
==========================================
- Hits        36597    36282     -315     
- Misses      25572    25837     +265     
- Partials     3886     3930      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen marked this pull request as ready for review October 11, 2024 11:03
@mregen mregen merged commit 0215eb5 into master Oct 11, 2024
118 of 120 checks passed
@mregen mregen deleted the revertclearchangemasks branch October 11, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants