Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeSet API: NamespaceUris cannot be instances of the Uri class #161

Closed
opcfoundation-org opened this issue Nov 23, 2022 · 1 comment · Fixed by #169
Closed

NodeSet API: NamespaceUris cannot be instances of the Uri class #161

opcfoundation-org opened this issue Nov 23, 2022 · 1 comment · Fixed by #169
Assignees
Labels
bug Something isn't working

Comments

@opcfoundation-org
Copy link
Contributor

Equality tests against NamespaceUris are exact string matches.
The Uri class can normalize Uris and result in false positives or false negatives.

@opcfoundation-org
Copy link
Contributor Author

Equality tests in the Server should be done with Uri.OriginalString
https://learn.microsoft.com/en-us/dotnet/api/system.uri.originalstring?view=net-6.0

The documentation should have a discussion of the need to use Uri.OriginalString when testing for equality inside client applications.

@barnstee barnstee added the bug Something isn't working label Nov 29, 2022
@MarkusHorstmann MarkusHorstmann linked a pull request Dec 17, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants