Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata cleanup. Approval. Synchronization. #169

Merged
merged 53 commits into from
Feb 28, 2023
Merged

Metadata cleanup. Approval. Synchronization. #169

merged 53 commits into from
Feb 28, 2023

Conversation

MarkusHorstmann
Copy link
Collaborator

@MarkusHorstmann MarkusHorstmann commented Dec 17, 2022 •
edited
Loading

This PR contains the following breaking changes:

  1. SDK, REST, GraphQL: The License field is no longer an enumeration/number, but a string that is intended to contain an SPDX license expression.
  2. SDK only: GetNodeSetDependencies parameter renamed from namespaceUri to modelUri (affects only clients that specify the parameter name in the method call).
  3. REST /infomodel/upload (UploadNamespace) now returns the identifier of the uploaded nodeset instead of the text "Upload successful!"
  4. GraphQL:
    4.1 PropertyModel.eURangeNodeId is now euRangeNodeId (proper camel casing), same for euRangeModelingRule and euRangeAccessLevel
    4.2 Previously marked as deprecated, now removed: namespaces, nameSpace, category, organisation, metadata, nodeSet, objectType, referenceType, variableType

@MarkusHorstmann
Pick up NodeSetModel 1.0.3
03f0a0a
@MarkusHorstmann
Special versioning semantics for core UA nodesets
f3c67c4
@MarkusHorstmann
Upload: properly match nodeset with legacy hash
fcf4c43
@MarkusHorstmann
GraphQL: enabled SubTypes query
1bf11ca
@MarkusHorstmann
Whitespace
c044bb4
@MarkusHorstmann
Test: Add OPC Core 1.05 nodeset
59733bc
@MarkusHorstmann
NamespaceMetadata, Category and Organization tables. Search performance.
4d57c09
@MarkusHorstmann
Legacy Metadata migration
15707c8
@MarkusHorstmann
Database migrations
92ff699
@MarkusHorstmann
Approval mechanism
fd6bef8
@MarkusHorstmann
CloudLibrary synchronization, download and upload
93269f8
@MarkusHorstmann
Database file store option (development only)
a5b5dbd
@MarkusHorstmann
File storage: make directory configurable
70930d8
@MarkusHorstmann
Adjust to latest NodeSet utilities
5677a6f
@MarkusHorstmann
Client: mark some methods obsolete, code cleanup
52ec39e
@MarkusHorstmann
Tests: upload tests for versioning. Cleanup.
8b1bd1a
@MarkusHorstmann
GraphQl schema: baseline (Prod 11-17-2022)
412f45a
@MarkusHorstmann
GraphQL schema: update
f30e260
@MarkusHorstmann
Merge main
73dd42d
This was linked to issues Dec 17, 2022
CreationTime not returned from Download/Find APIs #152
Closed
NodeSet API: NamespaceUris cannot be instances of the Uri class #161
Closed
Add approval to nodeset files and verify owner on upload #54
Closed
@MarkusHorstmann MarkusHorstmann linked an issue Feb 16, 2023 that may be closed by this pull request
Cannot upload any NodeSet2.xml via UA-CloudViewer #170
Closed
MarkusHorstmann added a commit to cesmii/CESMII-CloudLibrary that referenced this pull request Feb 16, 2023
@MarkusHorstmann
Sync to OPC Foundation PR OPCFoundation#169
df76d95
MarkusHorstmann added a commit to cesmii/CESMII-CloudLibrary that referenced this pull request Feb 16, 2023
@MarkusHorstmann
Merge PR OPCFoundation#169
1ea5e91
MarkusHorstmann added a commit to cesmii/CESMII-CloudLibrary that referenced this pull request Feb 17, 2023
@MarkusHorstmann
Merge pull request #32 from cesmii/cesmii/mhdev
24d99e1 
Sync to OPC PR OPCFoundation#169
@MarkusHorstmann MarkusHorstmann linked an issue Feb 17, 2023 that may be closed by this pull request
GraphQL: ModellingRule should follow UK English spelling #159
Closed
@MarkusHorstmann MarkusHorstmann linked an issue Feb 17, 2023 that may be closed by this pull request
GraphQL: Add support for more easily querying all referenced nodes for a given node/nodeid #157
Closed
@MarkusHorstmann
Copy link
Collaborator Author

@MarkusHorstmann do you have a running staging instance so we can confirm the compatibility?

This is now running in https://cloudlib-back-stage.azurewebsites.net/.

@BoBiene
Copy link
Collaborator

BoBiene commented Feb 22, 2023

@MarkusHorstmann do you have a running staging instance so we can confirm the compatibility?

This is now running in https://cloudlib-back-stage.azurewebsites.net/.

Thank you. Tests looks good.

BoBiene
BoBiene approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@BoBiene BoBiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

malessainray
malessainray approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@malessainray malessainray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkusHorstmann MarkusHorstmann merged commit 10ccce5 into main Feb 28, 2023
@MarkusHorstmann MarkusHorstmann mentioned this pull request Feb 28, 2023
Closed
@MarkusHorstmann MarkusHorstmann deleted the markush-metadata branch October 20, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnstee barnstee barnstee approved these changes

@BoBiene BoBiene BoBiene approved these changes

@malessainray malessainray malessainray approved these changes

@jwise-mfg jwise-mfg Awaiting requested review from jwise-mfg

Assignees

@MarkusHorstmann MarkusHorstmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@MarkusHorstmann @BoBiene @barnstee @malessainray