-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL: node set dependencies, full node graph #115
Conversation
as requested in #106 we need API stability. |
I strongly suggest converting this pullrequest to a draft as long as API stability is not ensured. Taking care of #48 first could ease the reviewing burden regarding API compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility with current graphql schema
Sadly I cannot login or register there for the live of me. Please get in touch with me so that we can perform tests against the staging deployment. |
Your logins should now work. Please try again. There was an issue with the mailer. |
These changes break our client side implementation in shipping product of dependency resolution for nodesets. With the instance hosted at https://uacloudlibrary.opcfoundation.org/ it works fine. I will follow up with more details on what specifically changed. |
Fixed and added a test. |
@MarkusHorstmann when will the latest changes in this pullrequest be deployed to the staging instance for integration testing? |
@malessainray It is now deployed at https://cloudlib-back-stage.azurewebsites.net/. |
The PR now retains full compability. Please re-review.
I could no longer spot incompatibilities with our released product. |
Co-authored-by: malessainray <[email protected]>
This PR uses a NodeSet model (from the CESMII Profile Designer) and the widely used GraphQL "Hot Chocolate" library to expose a fully resolved object graph of all nodes in the nodesets. It is deployed in the CESMII Stage Cloud Library for easier evaluation.
Open issues:
Try: