Versioning and nuget #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoBiene
commented
Mar 29, 2022
|
test of nuget publication: https://github.com/OPCFoundation/UA-CloudLibrary/packages/1333120 |
barnstee
requested changes
Apr 4, 2022
There was a problem hiding this comment.
- There was a change to the NuGet redist lic from the OPC Foundation last week, please update the text.
- Why change to async methods? If you do, please always add .ConfigureAwait(false) to awaits.
- Why the "throw new Exception(ex.Message)"? This removes a lot of exception info.
|
@barnstee I've updated the license headers and added the modifications to the async calls. |
|
Please fix conflicts. |
barnstee
reviewed
Apr 13, 2022
This reverts commit a6f6134.
… into versioning-and-nuget # Conflicts: # Opc.Ua.CloudLib.Client/ConvertMetadataToAddressspace.cs # Opc.Ua.CloudLib.Client/MetadataConverter.cs # Opc.Ua.CloudLib.Client/Models/DataResult.cs # Opc.Ua.CloudLib.Client/Models/MetadataResult.cs # Opc.Ua.CloudLib.Client/Models/ObjectResult.cs # Opc.Ua.CloudLib.Client/Models/ReferenceResult.cs # Opc.Ua.CloudLib.Client/Models/UANodesetResult.cs # Opc.Ua.CloudLib.Client/Models/VariableResult.cs # Opc.Ua.CloudLib.Client/PrebuiltQueries.cs # Opc.Ua.CloudLib.Client/RestClient.cs # Opc.Ua.CloudLib.Client/UACloudLibClient.cs # Opc.Ua.CloudLib.Client/WhereExpression.cs # SampleConsoleClient/Program.cs # UA-CloudLibrary.sln # UACloudLibraryGraphQLClient/UACloudLibClientLibrary/Models/InfoModel.cs # UACloudLibraryServer/UA-CloudLibrary.csproj
barnstee
approved these changes
Apr 22, 2022
|
Please resolve conflicts before merging. |
Done. Please look at my changes once again. |
barnstee
approved these changes
Apr 25, 2022
MarkusHorstmann
added a commit
to cesmii/CESMII-CloudLibrary
that referenced
this pull request
Apr 25, 2022
Pick up OPCFoundation PRs OPCFoundation#95 and OPCFoundation#101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #70
using https://dotnetfoundation.org/projects/nerdbank-gitversioning for versioning
(same as https://github.com/OPCFoundation/UA-.NETStandard)