Changed buf2val_ll to return int64_t. #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher59701
requested changes
Nov 7, 2024
There was a problem hiding this comment.
On line 1381, remove the cast to unsigned int: return (unsigned int)width_ll(true);
This is needed. We also need tests for this.
Also, in unit-tests, there is a test called BigArrayTest and that should be run by default, at least in theory. See this section of the libdap4/unit-tests/Makefile.am at about line 113:
If cppunit exists and big array test option are chosen, turn on BigArrayTest.
if CPPUNIT
if USE_BA
UNIT_TESTS +=BigArrayTest
endif
endif
|
jgallagher59701
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the changes to int64_t so tha the value of width_ll() is not cast from int64 to uint64.