Added XDMoD analytics metrics to jobs widget #3789
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some screenshots: 
|
johrstrom
reviewed
Sep 10, 2024
| }); | ||
|
|
||
| return rows; | ||
| } | ||
|
|
||
| function analyticsTable(analyticsContent) { |
There was a problem hiding this comment.
I think nested tables like this are an accessibility issue. I.e., they're confusing to navigate through.
I'd guess we need an additional column before id column and within it just text.
|
Looked this over and it's mostly good. Works well. I just have an issue with the HTML structure it creates - I don't think we should nest tables here. |
|
Changes to the look and feel to removed the nested tables: 
|
abujeda
force-pushed
the
998_xdmod_jobs_widget_enhancements
branch
from
5b62ec5
to
bf7bb3a
Compare
johrstrom
reviewed
Sep 12, 2024
johrstrom
reviewed
Sep 12, 2024
|
Sorry I lost the thread on this. Is it ready? I see you continue to make commits. |
|
Yes, it is now ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added analytics metrics from XDMoD to the jobs widget.
The analytics are added on demand, with an AJAX call to each job. This call is triggered when the user clicks on one of the jobs.
Fixes #998