Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject NTV2 files where GS_TYPE != SECONDS #1294

Closed
rouault opened this issue Feb 26, 2019 · 2 comments
Closed

Reject NTV2 files where GS_TYPE != SECONDS #1294

rouault opened this issue Feb 26, 2019 · 2 comments
Labels
good first issue Issues that offers a good place to start for new contributors pinned Prevent stale-bot from closing an issue
Milestone
7.0.0

Comments

@rouault
Copy link
Member

rouault commented Feb 26, 2019

Following discussion of https://lists.osgeo.org/pipermail/proj/2019-February/008246.html , it could be appropriate to error out if reading a NTv2 file with GS_TYPE header field value is different from "SECONDS" to avoid misinterpreting it.
Adding proper support for GS_TYPE != SECONDS is probably not needed since nobody does it as underlined in https://github.com/Esri/ntv2-file-routines (probably because PROJ doesn't handle it ! but that's nice to avoid too much creativity)
@rouault rouault added the good first issue Issues that offers a good place to start for new contributors label Feb 26, 2019
@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 8, 2020
@kbevers kbevers added the pinned Prevent stale-bot from closing an issue label Jan 8, 2020
@stale stale bot removed the wontfix label Jan 8, 2020
rouault added a commit to rouault/PROJ that referenced this issue Jan 8, 2020
@rouault
NTv2GridSet::open(): reject files with GS_TYPE!=SECONDS (fixes OSGeo#…
da93fe3 
…1294)
@kbevers kbevers added this to the 7.0.0 milestone Jan 8, 2020
@kbevers
Copy link
Member

kbevers commented Jan 23, 2020

Fixed in #1865

@kbevers kbevers closed this as completed Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that offers a good place to start for new contributors pinned Prevent stale-bot from closing an issue
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@rouault @kbevers