Speed-up geolocation-array based warping of Sentinel3 datasets #10812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value if VRT band type is Int64 or UInt64
…ource or VRT data types
… working datasets to 24 megapixels Fixes OSGeo#10809
pjonsson
reviewed
Nov 13, 2024
| GDALCopyWords(&paSrcData[idxBuffer], eSourceType, 0, | ||
| abyTemp, eVRTBandDataType, 0, 1); | ||
| CopyWord(&paSrcData[idxBuffer], eSourceType, abyTemp, | ||
| eVRTBandDataType); |
There was a problem hiding this comment.
@rouault From what I understand, for single-word copies with zero stride on both source and dest, you replaced calls to GDALCopyWords with calls to CopyWord which improved performance.
In #11254 I noticed that there is a 0 stride single word copy just below your change (rasterio.cpp:3402), do you think it might be worth doing the same replacement on more places in the source code? And what was the reason the next line in this file wasn't also replaced with a call to CopyWord?
There was a problem hiding this comment.
The CopyWord() method cannot be applied on the next line, because it relies on compile-time known source type, whereas in below line eVRTBandDataType is a runtime-known data type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10809
Timing back from ages (half an hour or so) to 20 seconds.
Also fixes a bug related to Int64/UInt64 VRT bands with nodata.