style: Fix unnecessary-comprehension (C416) (#4453)

gui/wxpython/lmgr/giface.py

@@ -54,7 +54,7 @@ def __init__(self, tree):
         self._tree = tree
 
     def __len__(self):
-        return len([layer for layer in self])
+        return len(list(self))
 
     def __iter__(self):
         """Iterates over the contents of the list."""
@@ -66,11 +66,11 @@ def __iter__(self):
 
     def __getitem__(self, index):
         """Select a layer from the LayerList using the index."""
-        return [layer for layer in self][index]
+        return list(self)[index]
 
     def __repr__(self):
         """Return a representation of the object."""
-        return "LayerList(%r)" % [layer for layer in self]
+        return "LayerList(%r)" % list(self)
 
     def GetSelectedLayers(self, checkedOnly=True):
         items = self._tree.GetSelectedLayer(multi=True, checkedOnly=checkedOnly)

gui/wxpython/timeline/frame.py

@@ -498,12 +498,9 @@ def _checkDatasets(self, datasets):
         if allDatasets:
             allDatasets = reduce(add, reduce(add, allDatasets))
             mapsets = tgis.get_tgis_c_library_interface().available_mapsets()
-            allDatasets = [
-                i
-                for i in sorted(
-                    allDatasets, key=lambda dataset_info: mapsets.index(dataset_info[1])
-                )
-            ]
+            allDatasets = sorted(
+                allDatasets, key=lambda dataset_info: mapsets.index(dataset_info[1])
+            )
 
         for dataset in datasets:
             errorMsg = _("Space time dataset <%s> not found.") % dataset

gui/wxpython/tplot/frame.py

@@ -1156,12 +1156,9 @@ def _checkDatasets(self, datasets, typ):
         if allDatasets:
             allDatasets = reduce(add, reduce(add, allDatasets))
             mapsets = tgis.get_tgis_c_library_interface().available_mapsets()
-            allDatasets = [
-                i
-                for i in sorted(
-                    allDatasets, key=lambda dataset_info: mapsets.index(dataset_info[1])
-                )
-            ]
+            allDatasets = sorted(
+                allDatasets, key=lambda dataset_info: mapsets.index(dataset_info[1])
+            )
 
         for dataset in datasets:
             errorMsg = _("Space time dataset <%s> not found.") % dataset

gui/wxpython/web_services/widgets.py

@@ -633,7 +633,7 @@ def UpdateWidgetsByCmd(self, cmd):
 
         # WMS standard - first layer in params is most bottom...
         # therefore layers order need to be reversed
-        l_st_list = [layer for layer in reversed(l_st_list)]
+        l_st_list.reverse()
         self.list.SelectLayers(l_st_list)
 
         params = {}

pyproject.toml

@@ -99,7 +99,6 @@ ignore = [
     "B909",    # loop-iterator-mutation
     "BLE001",  # blind-except
     "C414",    # unnecessary-double-cast-or-process
-    "C416",    # unnecessary-comprehension
     "COM812",  # missing-trailing-comma
     "COM818",  # trailing-comma-on-bare-tuple
     "D1",

python/grass/imaging/images2gif.py

@@ -265,7 +265,7 @@ def handleSubRectangles(self, images, subRectangles):
                 xy = (0, 0)
             if hasattr(xy, "__len__"):
                 if len(xy) == len(images):
-                    xy = [xxyy for xxyy in xy]
+                    xy = list(xy)
                 else:
                     raise ValueError("len(xy) doesn't match amount of images.")
             else:
@@ -594,7 +594,7 @@ def writeGifVisvis(
     # Check duration
     if hasattr(duration, "__len__"):
         if len(duration) == len(images):
-            duration = [d for d in duration]
+            duration = list(duration)
         else:
             raise ValueError("len(duration) doesn't match amount of images.")
     else:

python/grass/imaging/images2swf.py

@@ -796,7 +796,7 @@ def writeSwf(filename, images, duration=0.1, repeat=True):
     # Check duration
     if hasattr(duration, "__len__"):
         if len(duration) == len(images2):
-            duration = [d for d in duration]
+            duration = list(duration)
         else:
             raise ValueError("len(duration) doesn't match amount of images.")
     else:

python/grass/pygrass/gis/__init__.py

@@ -271,7 +271,7 @@ def mapsets(self, pattern=None, permissions=True):
             [...]
 
         """
-        mapsets = [mapset for mapset in self]
+        mapsets = [mapset for mapset in self]  # noqa: C416
         if permissions:
             mapsets = [
                 mapset

python/grass/pygrass/modules/grid/grid.py

@@ -145,7 +145,7 @@ def get_mapset(gisrc_src, gisrc_dst):
         copy_special_mapset_files(path_src, path_dst)
     src = Mapset(msrc, lsrc, gsrc)
     dst = Mapset(mdst, ldst, gdst)
-    visible = [m for m in src.visible]
+    visible = list(src.visible)
     if src.name not in visible:
         visible.append(src.name)
     dst.visible.extend(visible)
@@ -187,7 +187,7 @@ def rmloc(r):
         # change gisdbase to src
         env["GISRC"] = gisrc_src
         get_grp(group=grp, env_=env)
-        rasts = [r for r in get_grp.outputs.stdout.split()]
+        rasts = list(get_grp.outputs.stdout.split())
         # change gisdbase to dst
         env["GISRC"] = gisrc_dst
         rast2cp = [r for r in rasts if rmloc(r) not in all_rasts]
@@ -495,15 +495,15 @@ def __init__(
             self.gisrc_dst = write_gisrc(
                 self.n_mset.gisdbase, self.n_mset.location, self.n_mset.name
             )
-            rasters = [r for r in select(self.module.inputs, "raster")]
+            rasters = list(select(self.module.inputs, "raster"))
             if rasters:
                 copy_rasters(
                     rasters, self.gisrc_src, self.gisrc_dst, region=self.region
                 )
-            vectors = [v for v in select(self.module.inputs, "vector")]
+            vectors = list(select(self.module.inputs, "vector"))
             if vectors:
                 copy_vectors(vectors, self.gisrc_src, self.gisrc_dst)
-            groups = [g for g in select(self.module.inputs, "group")]
+            groups = list(select(self.module.inputs, "group"))
             if groups:
                 copy_groups(groups, self.gisrc_src, self.gisrc_dst, region=self.region)
         self.bboxes = split_region_in_overlapping_tiles(
@@ -590,7 +590,7 @@ def get_works(self):
         else:
             ldst, gdst = self.mset.location, self.mset.gisdbase
         cmd = self.module.get_dict()
-        groups = [g for g in select(self.module.inputs, "group")]
+        groups = list(select(self.module.inputs, "group"))
         for row, box_row in enumerate(self.bboxes):
             for col, box in enumerate(box_row):
                 inms = None

python/grass/pygrass/vector/basic.py

@@ -329,7 +329,7 @@ def __iter__(self):
         return (self.c_ilist.contents.value[i] for i in range(self.__len__()))
 
     def __repr__(self):
-        return "Ilist(%r)" % [i for i in self.__iter__()]
+        return "Ilist(%r)" % list(self.__iter__())
 
     def __contains__(self, item):
         return item in self.__iter__()

python/grass/pygrass/vector/table.py

@@ -944,7 +944,7 @@ def __getitem__(self, item):
             return self.by_name(item)
 
     def __repr__(self):
-        return "DBlinks(%r)" % [link for link in self.__iter__()]
+        return "DBlinks(%r)" % list(self.__iter__())
 
     def by_index(self, indx):
         """Return a Link object by index

python/grass/pygrass/vector/testsuite/test_table.py

@@ -65,7 +65,7 @@ def get_table_random_values(nrows, columns):
             raise TypeError("Unknown column type %s for: %s" % (ctype, cname))
         vals.append(COL2VALS[ctype](nrows))
         dtype.append((cname, vals[-1].dtype.str))
-    return np.array([v for v in zip(*vals)], dtype=dtype)
+    return np.array(list(zip(*vals)), dtype=dtype)
 
 
 class DBconnection:

scripts/i.oif/i.oif.py

@@ -122,9 +122,7 @@ def main():
 
     grass.message(_("Calculating Correlation Matrix..."))
     correlation = {}
-    s = grass.read_command(
-        "r.covar", flags="r", map=[band for band in bands], quiet=True
-    )
+    s = grass.read_command("r.covar", flags="r", map=list(bands), quiet=True)
 
     # We need to skip the first line, since r.covar prints the number of values
     lines = s.splitlines()