CI: Update to Black 22.3 with fixed Click #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of Click broke Black. The new version of Black fixes the issue. See also psf/black#2964
wenzeslaus
added
bug
|
The Black check now passes. CI-only change. No other files changed. Merging. |
wenzeslaus
added a commit
to wenzeslaus/grass-addons
that referenced
this pull request
Mar 29, 2022
- A new version of Click broke Black. The new version of Black fixes the issue. See also OSGeo/grass#2286 - New stable version of Black (22.1, 22.3) changes some of the code formatting. - Targeting Python >=3.7 adds trailing comma after kwargs. - Strings prefixed by u are replaced by plain strings which are unicode in Python 3. - Changes applied to all files. - Python 2 files are now ignored (to be fixed or removed in the future). - CI workflow synced to core repo.
wenzeslaus
added a commit
to OSGeo/grass-addons
that referenced
this pull request
Mar 30, 2022
- A new version of Click broke Black. The new version of Black fixes the issue. - New stable version of Black (22.1, 22.3) changes some of the code formatting. - Targeting Python >=3.7 adds trailing comma after `**kwargs`. - Strings prefixed by u are replaced by plain strings which are Unicode in Python 3. - Changes applied to all files. - Python 2 files are now ignored (to be fixed or removed in the future). - CI workflow synced to core repo. - See also OSGeo/grass#2212 for the update to stable Black in core repo. - See also OSGeo/grass#2286 for the Click-related update.
|
@wenzeslaus don't we need this also in the relbranch80? I see related CI errors in backports... May I backport it? |
|
Backporting this would require backporting #2212 first which didn't seem as a backport candidate by itself. Alternatively, you can remove the Black check (delete the black.yml file) from the release branch because unlike the others, it does not check any functionality. |
|
Another solution is to pin the Click version which is suggested in the Black issue I think. |
|
I see the suggestion |
|
Likely pip install before or with Black will work. |
neteler
added a commit
to neteler/grass
that referenced
this pull request
Apr 8, 2022
|
This is in 8.2 and the test was dropped from 8.0 branch in 6509178. Removing the backport label. |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
A new version of Click broke Black. The new version of Black fixes the issue. See also psf/black#2964
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
A new version of Click broke Black. The new version of Black fixes the issue. See also psf/black#2964
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
A new version of Click broke Black. The new version of Black fixes the issue. See also psf/black#2964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of Click broke Black. The new version of Black fixes the issue.
See also psf/black#2964