Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: Fixed E722 in ii2t_gis_set.py #4417

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Conversation

arohanajit
Copy link
Contributor

Fixed E722: bare 'except' in iit2t_gis_set.py. Added general catchall Exception for cases with multiple errors. Other were mostly OSError and shutil.Error. Also print error message in the error notification

@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python labels Sep 30, 2024
@echoix
Copy link
Member

echoix commented Sep 30, 2024

Was the branch too outdated yet?

@arohanajit
Copy link
Contributor Author

Yeah, even though I cloned a fresh copy this morning. Normally I try to update the branch when reqd so that PR are in line with the latest version

@echoix
Copy link
Member

echoix commented Sep 30, 2024

But if there aren't potential semantic conflicts, or not too outdated (new enforcements, similar files changed), it doesn't matter to be a couple commits out of date. Each push is about 1h of CI x 20 runners, shared between all OSGeo projects.

@arohanajit
Copy link
Contributor Author

Oh ok, got it. I do this to avoid any potential merge conflicts but will let it be in the future

@petrasovaa petrasovaa added this to the 8.5.0 milestone Oct 1, 2024
@echoix echoix enabled auto-merge (squash) October 1, 2024 20:03
@echoix echoix merged commit 3f61cd7 into OSGeo:main Oct 1, 2024
26 checks passed
@arohanajit arohanajit deleted the 722-ii2tgis branch October 2, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants